Use PyTorch's p2p access enable function #1991
Closed
+0
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D48939723 |
banitag1
pushed a commit
to banitag1/FBGEMM
that referenced
this pull request
Sep 4, 2023
…ytorch#1991) Summary: Reland the diff after fixing the issues with some initialization issues. cudaEnablePeerAccess only enables cross device access for memory allocated with cudaMalloc. When using other cuda APIs such cuMemMap, peer access is managed differently. expandable_segments:True in PyTorch uses cuMemMap, so code that just calls cudaEnablePeerAccess is not sufficient to enable cross-device copies. This patch switching the p2p access enabling functions to use PyTorchs `get_p2p_access` which lets its allocator figure out how to correctly enable p2p access for that memory. In the normal case (expandable_segments:False), this code performs exactly the same cuda calls as before. Differential Revision: D48939723
banitag1
force-pushed
the
export-D48939723
branch
from
de33565 to
5a35c11
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48939723 |
banitag1
pushed a commit
to banitag1/FBGEMM
that referenced
this pull request
Sep 4, 2023
…ytorch#1991) Summary: Reland the diff after fixing the issues with some initialization issues. cudaEnablePeerAccess only enables cross device access for memory allocated with cudaMalloc. When using other cuda APIs such cuMemMap, peer access is managed differently. expandable_segments:True in PyTorch uses cuMemMap, so code that just calls cudaEnablePeerAccess is not sufficient to enable cross-device copies. This patch switching the p2p access enabling functions to use PyTorchs `get_p2p_access` which lets its allocator figure out how to correctly enable p2p access for that memory. In the normal case (expandable_segments:False), this code performs exactly the same cuda calls as before. Differential Revision: D48939723
banitag1
force-pushed
the
export-D48939723
branch
from
5a35c11 to
d57362e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48939723 |
banitag1
pushed a commit
to banitag1/FBGEMM
that referenced
this pull request
Sep 4, 2023
…ytorch#1991) Summary: Reland the diff after fixing the issues with some initialization issues. cudaEnablePeerAccess only enables cross device access for memory allocated with cudaMalloc. When using other cuda APIs such cuMemMap, peer access is managed differently. expandable_segments:True in PyTorch uses cuMemMap, so code that just calls cudaEnablePeerAccess is not sufficient to enable cross-device copies. This patch switching the p2p access enabling functions to use PyTorchs `get_p2p_access` which lets its allocator figure out how to correctly enable p2p access for that memory. In the normal case (expandable_segments:False), this code performs exactly the same cuda calls as before. Differential Revision: D48939723
banitag1
force-pushed
the
export-D48939723
branch
from
d57362e to
077967a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48939723 |
banitag1
pushed a commit
to banitag1/FBGEMM
that referenced
this pull request
Sep 4, 2023
…ytorch#1991) Summary: Reland the diff after fixing the issues with some initialization issues. cudaEnablePeerAccess only enables cross device access for memory allocated with cudaMalloc. When using other cuda APIs such cuMemMap, peer access is managed differently. expandable_segments:True in PyTorch uses cuMemMap, so code that just calls cudaEnablePeerAccess is not sufficient to enable cross-device copies. This patch switching the p2p access enabling functions to use PyTorchs `get_p2p_access` which lets its allocator figure out how to correctly enable p2p access for that memory. In the normal case (expandable_segments:False), this code performs exactly the same cuda calls as before. Differential Revision: D48939723
banitag1
force-pushed
the
export-D48939723
branch
from
077967a to
643088e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48939723 |
banitag1
pushed a commit
to banitag1/FBGEMM
that referenced
this pull request
Sep 4, 2023
…ytorch#1991) Summary: Reland the diff after fixing the issues with some initialization issues. cudaEnablePeerAccess only enables cross device access for memory allocated with cudaMalloc. When using other cuda APIs such cuMemMap, peer access is managed differently. expandable_segments:True in PyTorch uses cuMemMap, so code that just calls cudaEnablePeerAccess is not sufficient to enable cross-device copies. This patch switching the p2p access enabling functions to use PyTorchs `get_p2p_access` which lets its allocator figure out how to correctly enable p2p access for that memory. In the normal case (expandable_segments:False), this code performs exactly the same cuda calls as before. Differential Revision: D48939723
banitag1
force-pushed
the
export-D48939723
branch
from
643088e to
52b7ea7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48939723 |
banitag1
pushed a commit
to banitag1/FBGEMM
that referenced
this pull request
Sep 5, 2023
…ytorch#1991) Summary: Reland the diff after fixing the issues with some initialization issues. cudaEnablePeerAccess only enables cross device access for memory allocated with cudaMalloc. When using other cuda APIs such cuMemMap, peer access is managed differently. expandable_segments:True in PyTorch uses cuMemMap, so code that just calls cudaEnablePeerAccess is not sufficient to enable cross-device copies. This patch switching the p2p access enabling functions to use PyTorchs `get_p2p_access` which lets its allocator figure out how to correctly enable p2p access for that memory. In the normal case (expandable_segments:False), this code performs exactly the same cuda calls as before. Reviewed By: zdevito Differential Revision: D48939723
banitag1
force-pushed
the
export-D48939723
branch
from
52b7ea7 to
ac93de4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48939723 |
banitag1
pushed a commit
to banitag1/FBGEMM
that referenced
this pull request
Sep 5, 2023
…ytorch#1991) Summary: Reland the diff after fixing the issues with some initialization issues. cudaEnablePeerAccess only enables cross device access for memory allocated with cudaMalloc. When using other cuda APIs such cuMemMap, peer access is managed differently. expandable_segments:True in PyTorch uses cuMemMap, so code that just calls cudaEnablePeerAccess is not sufficient to enable cross-device copies. This patch switching the p2p access enabling functions to use PyTorchs `get_p2p_access` which lets its allocator figure out how to correctly enable p2p access for that memory. In the normal case (expandable_segments:False), this code performs exactly the same cuda calls as before. Reviewed By: zdevito Differential Revision: D48939723
banitag1
force-pushed
the
export-D48939723
branch
from
ac93de4 to
9081083
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48939723 |
banitag1
pushed a commit
to banitag1/FBGEMM
that referenced
this pull request
Sep 5, 2023
…ytorch#1991) Summary: Reland the diff after fixing the issues with some initialization issues. cudaEnablePeerAccess only enables cross device access for memory allocated with cudaMalloc. When using other cuda APIs such cuMemMap, peer access is managed differently. expandable_segments:True in PyTorch uses cuMemMap, so code that just calls cudaEnablePeerAccess is not sufficient to enable cross-device copies. This patch switching the p2p access enabling functions to use PyTorchs `get_p2p_access` which lets its allocator figure out how to correctly enable p2p access for that memory. In the normal case (expandable_segments:False), this code performs exactly the same cuda calls as before. Reviewed By: zdevito Differential Revision: D48939723
banitag1
force-pushed
the
export-D48939723
branch
from
9081083 to
719a963
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48939723 |
2 similar comments
|
This pull request was exported from Phabricator. Differential Revision: D48939723 |
|
This pull request was exported from Phabricator. Differential Revision: D48939723 |
banitag1
force-pushed
the
export-D48939723
branch
from
719a963 to
9ed959f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48939723 |
banitag1
pushed a commit
to banitag1/pytorch
that referenced
this pull request
Sep 5, 2023
Summary: Pull Request resolved: pytorch/FBGEMM#1991 Test Plan: sandcastle Reviewed By: zdevito Differential Revision: D48939723
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Sep 6, 2023
…8589) Summary: Pull Request resolved: pytorch/FBGEMM#1991 Test Plan: sandcastle Reviewed By: zdevito Differential Revision: D48939723 Pull Request resolved: #108589 Approved by: https://github.com/zdevito
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Reland the diff after fixing the issues with some initialization issues.
cudaEnablePeerAccess only enables cross device access for memory allocated with cudaMalloc. When using other cuda APIs such cuMemMap, peer access is managed differently.
expandable_segments:True in PyTorch uses cuMemMap, so code that just calls cudaEnablePeerAccess is not sufficient to enable cross-device copies. This patch switching the p2p access enabling functions
to use PyTorchs
get_p2p_accesswhich lets its allocator figure out how to correctly enable p2p access for that memory.In the normal case (expandable_segments:False), this code performs exactly the same cuda calls as before.
Differential Revision: D48939723