[i will merge] Upgrade python version to 3.9 #488
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're trying to upgrade from 3.8 to a more modern Python version to use some newer features like
3.8 is reaching EOL imminently so we must upgrade to at least 3.9 https://devguide.python.org/versions/
If we were to do what PyTorch does we'd simply upgrade to 3.9 and try to avoid using 3.10+ features pytorch/rfcs#65
Upgrading to 3.9
This also works and is probably the least controversial thing to merge
Upgrading to 3.10
This just works, CI is green so we can merge this PR as is
Upgrading to 3.11
This made the dora optimizer crash - cc @jeromeku in case you're interested