KEMBAR78
Add a test for map_location="cpu" by jerryzh168 · Pull Request #497 · pytorch/ao · GitHub
Skip to content

Conversation

@jerryzh168
Copy link
Contributor

Summary:
torchtune is using torch.load(file_name, map_location="cpu", mmap=True), so we add a test to make sure this works with tensor subclass API

Test Plan:
python test/quantization/test_quant_api.py -k test_quantized_tensor_subclass_save_load_map_location

Reviewers:

Subscribers:

Tasks:

Tags:

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 10, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/497

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 9da3032 with merge base 05038a1 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 10, 2024
Summary:
torchtune is using torch.load(file_name, map_location="cpu", mmap=True), so we add a test
to make sure this works with tensor subclass API

Test Plan:
python test/quantization/test_quant_api.py -k test_quantized_tensor_subclass_save_load_map_location

Reviewers:

Subscribers:

Tasks:

Tags:
@msaroufim msaroufim self-requested a review July 10, 2024 23:57
@jerryzh168 jerryzh168 merged commit 1029df3 into pytorch:main Jul 11, 2024
@jerryzh168 jerryzh168 deleted the map_location branch July 11, 2024 23:47
yanbing-j pushed a commit to yanbing-j/ao that referenced this pull request Dec 9, 2024
That updates objcopy from 2.32 to 2.35

To workaround `objcopy: unrecognized option '--set-section-alignment'` introduced by  pytorch/pytorch#124272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants