KEMBAR78
Introduce functional submodule by mthrok · Pull Request #1003 · pytorch/audio · GitHub
Skip to content

Conversation

@mthrok
Copy link
Contributor

@mthrok mthrok commented Nov 3, 2020

The torchaudio/functional.py file has grown to +2.3k LoC with the wide range of functionalities.
We perform a small refactoring on it by introducing torchaudio/functional directory (this PR), then extracting the filterings (#1004).

There is no API change. Users are still expected to use torchaudio.functional.XXX.

@mthrok mthrok changed the title Add functional submodule Introduce functional submodule Nov 3, 2020
@mthrok mthrok force-pushed the refactor-functional1 branch from b42b397 to 0840129 Compare November 5, 2020 18:38
@cpuhrsch cpuhrsch marked this pull request as ready for review November 6, 2020 17:34
@mthrok mthrok merged commit f04b362 into pytorch:master Nov 6, 2020
@mthrok mthrok deleted the refactor-functional1 branch November 6, 2020 20:09
mpc001 pushed a commit to mpc001/audio that referenced this pull request Aug 4, 2023
…k_example

Implemented a Siamese Network Example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants