Fbsync #1121
Merged
Fbsync #1121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbshipit-source-id: 4fb853c391900d3070b936e5a3e4609eb78a780d
Summary: [10:30:47: cpuhrsch@devvm3140 pytorch]$ ./fb_build/import_audio.sh Reviewed By: vincentqb Differential Revision: D21282421 fbshipit-source-id: 9bde1455ca6a19defbf33dbbfc5f0d49a8e4dc6a
Summary: Import Up to #664 Reviewed By: cpuhrsch Differential Revision: D21728204 fbshipit-source-id: 648dd622087fa762194ca5f89a310500e777263d
Summary: Turned out .use_external_sox is not necessary for building torchaudio in fbcode. Reviewed By: vincentqb Differential Revision: D21792939 fbshipit-source-id: c0fb5173c6533e67114f50ddc8e9425bd129574f
Summary: import torchaudio 0.5.0 in fbcode using import_audio.sh: Reviewed By: vincentqb Differential Revision: D21884426 fbshipit-source-id: b6f2cc308e597caef2dd767c315b167c09fb0d4c
Summary: The previous implementation of parameterized testing worked by modifying test.common_utils inplace. This doesn't work in general because unittest's contract with test modules is such that it must be able to load the module and run the test itself. Because the previous implementation needed to load the module and modify it, it is incompatible. Reviewed By: mthrok Differential Revision: D21964676 fbshipit-source-id: 9bb71e8c3f9fab074239b22306f3bbddb0f3975b
Summary: Import torchaudio up to #719 Reviewed By: zhangguanheng66 Differential Revision: D22119491 fbshipit-source-id: e14842278a32c9373179fc132e8111a0ffe66d93
fbshipit-source-id: 5113fe0c527595e4227ff827253b7414abbdf7ac
fbshipit-source-id: 798decc90db4f13770e97cdce3c0df7d5421b2a3
Summary: Import torchaudio 20200723 #814 Reviewed By: fmassa Differential Revision: D22666393 fbshipit-source-id: 50df07b5c158fe4e95ada7ea54381b2e26f6aecd
Summary: Raise and assert used to have a hard-coded error message "Exception". User provided error message was ignored. This PR adds support to represent user's error message in TorchScript. This breaks backward compatibility because now we actually need to script the user's error message, which can potentially contain unscriptable expressions. Such programs can break when scripting, but saved models can still continue to work. Increased an op count in test_mobile_optimizer.py because now we need aten::format to form the actual exception message. This is built upon an WIP PR: pytorch/pytorch#34112 by driazati Pull Request resolved: pytorch/pytorch#41907 Reviewed By: ngimel Differential Revision: D22778301 Pulled By: gmagogsfm fbshipit-source-id: 2b94f0db4ae9fe70c4cd03f4048e519ea96323ad
Summary: Up to #804 Reviewed By: vincentqb Differential Revision: D22947671 fbshipit-source-id: d1a005cec2f1a00913c41eda380b9f4b993ef779
Reviewed By: ashwinp-fb Differential Revision: D22955630 fbshipit-source-id: f00ef17a905e4c7cd9196c8924db39f9cdfe8cfa
Reviewed By: cpuhrsch Differential Revision: D23273584 fbshipit-source-id: 2fe7effa11b7f7cdf0cee1da6b1cac5556e9f55b
Summary: Up to #914 Reviewed By: vincentqb, cpuhrsch Differential Revision: D23846718 fbshipit-source-id: 9feb4e58563b900965467bd9ff66c979211c50df
Summary: this fixes some regressions introduced by D24121305. fairseq configuration is changing from command line to dataclasses (via hydra eventually) which no longer supports option aliases. one such alias is --max-sentences / --batch-size, and D24121305 removed --max-sentences as --batch-size is more appropriate (fairseq is not just an nlp framework dealing with sentences). unfortunately it seems some existing flows broke and this diff attempts to fix this Differential Revision: D24142488 fbshipit-source-id: 075180ea10a9d706a3f8d64b978d66dfd83c3d2b
Reviewed By: cpuhrsch Differential Revision: D24606263 fbshipit-source-id: 4301b1df84d20c671783ec34c52d5b257374abf1
Summary: Import up to #1066 Reviewed By: cpuhrsch Differential Revision: D25373068 fbshipit-source-id: 890d36a25259b93428b3037c3123ff5a2cacfa04
|
thanks! |
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Dec 13, 2022
This is just to clarify the known issue (https://pytorch.org/docs/stable/notes/faq.html#my-data-loader-workers-return-identical-random-numbers) that `DataLoader`s and random number generators from external libraries (such as Numpy) may not interact as expected. I think this should be clarified in the beginner's tutorial on Datasets and DataLoaders as it uses `np.random.randint` in its `RandomCrop` example. Co-authored-by: holly1238 <77758406+holly1238@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync with fbcode.