Add AudioMetaData.__str__ override #1339
Conversation
|
Hi @majabojarska! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
torchaudio/backend/common.py
Outdated
|
|
||
| def __str__(self): | ||
| return ( | ||
| f"{self.__class__.__name__}(" |
There was a problem hiding this comment.
Although this is correct and more generic, TorchScript compiler has restriction in the kind of attributes it can access, and self.__class__ is not accessible. Can you hard-code it?
There was a problem hiding this comment.
Thanks for the tip. I commited the necessary change.
|
Thanks! |
3 participants
Makes
AudioMetaDataprint-friendly.Closes #1323