KEMBAR78
Refactor Kaldi compatibility tests by hwangjeff · Pull Request #1359 · pytorch/audio · GitHub
Skip to content

Conversation

@hwangjeff
Copy link
Contributor

@hwangjeff hwangjeff commented Mar 5, 2021

Stack from ghstack:

hwangjeff added a commit that referenced this pull request Mar 5, 2021
ghstack-source-id: 95de1f2
Pull Request resolved: #1359
hwangjeff added a commit that referenced this pull request Mar 5, 2021
ghstack-source-id: 311a508
Pull Request resolved: #1359
Copy link
Contributor

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

hwangjeff added a commit that referenced this pull request Mar 5, 2021
ghstack-source-id: 8b2dda1
Pull Request resolved: #1359
@hwangjeff
Copy link
Contributor Author

thanks! made a small update to the test readme to account for the movement of files

@hwangjeff hwangjeff marked this pull request as ready for review March 5, 2021 17:42
@hwangjeff hwangjeff changed the base branch from gh/hwangjeff/2/base to master March 5, 2021 17:57
@hwangjeff hwangjeff merged commit 301a6e3 into master Mar 5, 2021
@hwangjeff hwangjeff deleted the gh/hwangjeff/2/head branch March 5, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants