Replace sox conversion macros with Tensor op #1370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conversion from signed integer with left shift causes UB (negative left shift)
This reverts commit 8e71263.
cpuhrsch
reviewed
Mar 8, 2021
| chunk = chunk.to(c10::ScalarType::Double); | ||
| chunk *= 2147483648.; | ||
| chunk.clamp_(INT32_MIN, INT32_MAX); | ||
| chunk = chunk.to(c10::ScalarType::Int); |
There was a problem hiding this comment.
I'm not sure that this will guarantee that chunk is contiguous afterwards. I'd call into "contiguous" anyway to be sure. Same applies for the other cases.
cpuhrsch
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SOX_SIGNED_16BIT_TO_SAMPLEandSOX_SIGNED_32BIT_TO_SAMPLEuses left shift on signed integers, which is UB.This PR replaces them (and other sox macros for
uint8andfloatas well) with Tensor operations.