Lint code style and remove PY2 compatibility #1386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powerexploit
force-pushed
the
fix-bugs
branch
2 times, most recently
from
424ef55 to
bbfb8ce
Compare
4 tasks
|
@mthrok review the updated PR and merge the fixes. |
mthrok
suggested changes
Mar 16, 2021
powerexploit
force-pushed
the
fix-bugs
branch
2 times, most recently
from
3451b3e to
48f9c00
Compare
- Fixed implicit object inheritance - Use `max` built-in to get the maximum of two values - Remove unnecessary use of comprehension
mthrok
changed the title
|
Thanks! |
Thanks @mthrok . Activating analysis will help you to continuously analyze repo for code quality issues and fix commonly occurring issues using the auto-fix feature. I would like to share some steps to activate DeepSource : |
Thanks for the proposal but adding a new tool for our framework is not something torchaudio can decide on its own. The best way to make it adopted is to propose it in PyTorch repository https://github.com/pytorch/pytorch and get an approval, then we can discuss the adaptation steps. |
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Dec 13, 2022
* Update spatial_transformer_tutorial.py * Update fgsm_tutorial.py * Update beginner_source/fgsm_tutorial.py Co-authored-by: Eli Uriegas <1700823+seemethere@users.noreply.github.com> Co-authored-by: Eli Uriegas <1700823+seemethere@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi 👋 I ran the DeepSource static analyzer on the forked copy of this repo and found some interesting code quality issues. This PR fixes a few of them.
Summary of Fixes
Type of change
Checklist: