Add support for 24-bit signed LPCM wav in sox_io backend #1389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iseessel
force-pushed
the
support-signed-24-bit-int
branch
from
d53aefc to
803cc7a
Compare
iseessel
commented
Mar 13, 2021
|
@mthrok Let me know what you think! |
mthrok
reviewed
Mar 14, 2021
torchaudio/csrc/sox/utils.cpp
Outdated
| case 24: // Cast 24-bit to 32-bit. That is each data chunk will | ||
| // implicitly perform 8 left-shifts. | ||
| std::cout << "Warning: Casting 24-bit signed PCM to torch::kInt32"; | ||
| return torch::kInt32; |
There was a problem hiding this comment.
I just realized that adding a warning here will issue warning regardless of the value of normalize. Ideally, the warning should be issued only when normalize=False and the input format is 24-bit PCM WAV, but let's keep that from this PR. So, let's simplify the case for 24-bit.
case 24:
case 32:
return torch::kInt32;There was a problem hiding this comment.
Would you like me to add warnings to apply_effects_file and apply_effects_fileobj?
iseessel
force-pushed
the
support-signed-24-bit-int
branch
from
803cc7a to
6a8a05f
Compare
|
Changes have been addressed.
|
If you have time and interest, please do so. The following is the direction I think works.
If you have time, please do so. I have filed a task T86709147 as well. |
mthrok
changed the title
|
Thanks! |
vincentqb
pushed a commit
to vincentqb/audio
that referenced
this pull request
Mar 17, 2021
vincentqb
added a commit
that referenced
this pull request
Mar 17, 2021
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.