Example for Mu law encoding #1586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
|
PR for Issue #1564 |
|
@mthrok please help to review |
|
@nateanl please help to review |
nateanl
approved these changes
Aug 4, 2021
There was a problem hiding this comment.
LGTM. Thanks for the change @harishsdev. We can merge it after fixing all nits!
torchaudio/transforms.py
Outdated
| Example | ||
| >>> waveform, sample_rate = torchaudio.load('test.wav', normalization=True) |
There was a problem hiding this comment.
nit: normalization is changed to normalize now. Let's replace it.
Suggested change
| >>> waveform, sample_rate = torchaudio.load('test.wav', normalization=True) | |
| >>> waveform, sample_rate = torchaudio.load('test.wav', normalize=True) |
torchaudio/transforms.py
Outdated
| Example | ||
| >>> waveform, sample_rate = torchaudio.load('test.wav', normalization=True) | ||
| >>> transform = torchaudio.transforms.MuLawEncoding(quantization_channels = 512) |
There was a problem hiding this comment.
nit: remove spaces.
Suggested change
| >>> transform = torchaudio.transforms.MuLawEncoding(quantization_channels = 512) | |
| >>> transform = torchaudio.transforms.MuLawEncoding(quantization_channels=512) |
nateanl
reviewed
Aug 4, 2021
torchaudio/transforms.py
Outdated
| quantization_channels (int, optional): Number of channels. (Default: ``256``) | ||
| Example | ||
There was a problem hiding this comment.
We can delete the line break to be consistent with other examples.
Suggested change
|
Thanks! I have merged it to main branch. |
|
@nateanl thanks for merging it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example for Mu law encoding