KEMBAR78
Enable audio windows cuda tests by mszhanyi · Pull Request #1777 · pytorch/audio · GitHub
Skip to content

Enable audio windows cuda tests #1777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Sep 27, 2021
Merged

Enable audio windows cuda tests #1777

merged 25 commits into from
Sep 27, 2021

Conversation

@mszhanyi
Copy link
Contributor

@mszhanyi mszhanyi commented Sep 18, 2021 •
edited by mthrok
Loading

Enable unittest_windows_gpu.

  1. add cuda_install (runtime) step.
  2. add update cuda driver step.
  3. add set cuda envs.
  4. enable TORCHAUDIO_TEST_FORCE_CUDA=1

These 4 changes have to work together to pass unittest_windows_gpu

closes #1565

@mszhanyi mszhanyi marked this pull request as draft September 18, 2021 08:32
@mszhanyi
Copy link
Contributor Author

@mthrok If it's not urgent. I'll split this PR to multiple small PRs to submit because Nikita might not approve big PRs like this.
I think it's a transient issue for unittest_windows_gpu_py3.9, it should be passed by rerunning it.
And it looks there's nothing with binary_linux_conda_xxx failure.

@mszhanyi mszhanyi mentioned this pull request Sep 23, 2021
Merged
@mszhanyi mszhanyi marked this pull request as ready for review September 27, 2021 03:39
@mszhanyi mszhanyi changed the title [Testing] enable windows cudatests enable windows cuda tests Sep 27, 2021
@mszhanyi mszhanyi changed the title enable windows cuda tests enable audio windows cuda tests Sep 27, 2021
@mthrok mthrok changed the title enable audio windows cuda tests Enable audio windows cuda tests Sep 27, 2021
@mthrok
Copy link
Contributor

mthrok commented Sep 27, 2021

Looks good. All the logs of unitttest_windows_gpu_* shows RNNT-loss tests ran and passed.
Thank you @mszhanyi !

@malfet Could you take a second look?

@mthrok
Copy link
Contributor

mthrok commented Sep 27, 2021

I looked at the build logs and it do not look like CUDA code is compiled.
The Windows binary packages do not have CUDA.
@mszhanyi @malfet I know this is a lot to ask, but it would really help us if you can look into it. (as a different scope than this PR)

@mszhanyi
Copy link
Contributor Author

I looked at the build logs and it do not look like CUDA code is compiled.
The Windows binary packages do not have CUDA.
@mszhanyi @malfet I know this is a lot to ask, but it would really help us if you can look into it. (as a different scope than this PR)

Sure. I'll look binary_windows_xxx_gpu workflow tomorrow. there should be another PR for binary_windows_xxx_gpu workflow

@malfet malfet merged commit d98c884 into pytorch:main Sep 27, 2021
mthrok pushed a commit to mthrok/audio that referenced this pull request Dec 13, 2022
@lithuak @holly1238
Fix the number in example (pytorch#1777)
b9f9e5a 
The further code (and the closer code to it) uses a random int number from [4, 5], not [3, 5]

Co-authored-by: Holly Sweeney <77758406+holly1238@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seemethere seemethere Awaiting requested review from seemethere

@malfet malfet Awaiting requested review from malfet

1 more reviewer

@mthrok mthrok mthrok approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Windows GPU CI is not running GPU tests

4 participants

@mszhanyi @mthrok @malfet @facebook-github-bot