Move XNNPACKQuantizer from PyTorch to ExecuTorch #7804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7804
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 Cancelled Jobs, 3 Unrelated FailuresAs of commit 67d64fe with merge base 7600f18 ( CANCELLED JOBS - The following jobs were cancelled. Please retry:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68191752 |
digantdesai
added
release notes: xnnpack
digantdesai
added a commit
to digantdesai/pytorch
that referenced
this pull request
Jan 21, 2025
Summary: X-link: pytorch/executorch#7804 Pull Request resolved: pytorch#144940 This migrates XNNPACKQuantizer from PyTorch to ExecuTorch. Rationale: Main motivation is to avoid pytorch pin update in OSS after updating XNNPACKQuantizer, which can be rather frequent. Other impact and considerations: - PT2e flow (which lives in PyTorch) relies havily on XNNPACKQuantizer for a "example" implementation for quantizer and more importantly tests. Fow now, we will keep the torch.ao.quantization.xnnpack_quantizer as is but mark is as not BC, and deprecated to discourace future new dependencies on it. - Other OSS repository using XNNPACKQuantizer from PyTorch now have to take an additional dependency on ExecuTorch. Test Plan: CI Differential Revision: D68191752
mcr229
approved these changes
Jan 22, 2025
digantdesai
force-pushed
the
export-D68191752
branch
from
febc06e to
0755307
Compare
digantdesai
added a commit
to digantdesai/executorch-1
that referenced
this pull request
Jan 22, 2025
Summary: Pull Request resolved: pytorch#7804 X-link: pytorch/pytorch#144940 This migrates XNNPACKQuantizer from PyTorch to ExecuTorch. Rationale: Main motivation is to avoid pytorch pin update in OSS after updating XNNPACKQuantizer, which can be rather frequent. Other impact and considerations: - PT2e flow (which lives in PyTorch) relies havily on XNNPACKQuantizer for a "example" implementation for quantizer and more importantly tests. Fow now, we will keep the torch.ao.quantization.xnnpack_quantizer as is but mark is as not BC, and deprecated to discourace future new dependencies on it. - Other OSS repository using XNNPACKQuantizer from PyTorch now have to take an additional dependency on ExecuTorch. Reviewed By: mcr229 Differential Revision: D68191752
|
This pull request was exported from Phabricator. Differential Revision: D68191752 |
digantdesai
added a commit
to digantdesai/executorch-1
that referenced
this pull request
Jan 22, 2025
Summary: Pull Request resolved: pytorch#7804 X-link: pytorch/pytorch#144940 This migrates XNNPACKQuantizer from PyTorch to ExecuTorch. Rationale: Main motivation is to avoid pytorch pin update in OSS after updating XNNPACKQuantizer, which can be rather frequent. Other impact and considerations: - PT2e flow (which lives in PyTorch) relies havily on XNNPACKQuantizer for a "example" implementation for quantizer and more importantly tests. Fow now, we will keep the torch.ao.quantization.xnnpack_quantizer as is but mark is as not BC, and deprecated to discourace future new dependencies on it. - Other OSS repository using XNNPACKQuantizer from PyTorch now have to take an additional dependency on ExecuTorch. Reviewed By: mcr229 Differential Revision: D68191752
digantdesai
force-pushed
the
export-D68191752
branch
from
0755307 to
d6d19ce
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68191752 |
digantdesai
added a commit
to digantdesai/executorch-1
that referenced
this pull request
Jan 22, 2025
Summary: Pull Request resolved: pytorch#7804 X-link: pytorch/pytorch#144940 This migrates XNNPACKQuantizer from PyTorch to ExecuTorch. Rationale: Main motivation is to avoid pytorch pin update in OSS after updating XNNPACKQuantizer, which can be rather frequent. Other impact and considerations: - PT2e flow (which lives in PyTorch) relies havily on XNNPACKQuantizer for a "example" implementation for quantizer and more importantly tests. Fow now, we will keep the torch.ao.quantization.xnnpack_quantizer as is but mark is as not BC, and deprecated to discourace future new dependencies on it. - Other OSS repository using XNNPACKQuantizer from PyTorch now have to take an additional dependency on ExecuTorch. Reviewed By: mcr229 Differential Revision: D68191752
digantdesai
force-pushed
the
export-D68191752
branch
from
d6d19ce to
3a19dbf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68191752 |
digantdesai
added a commit
to digantdesai/executorch-1
that referenced
this pull request
Jan 22, 2025
Summary: Pull Request resolved: pytorch#7804 X-link: pytorch/pytorch#144940 This migrates XNNPACKQuantizer from PyTorch to ExecuTorch. Rationale: Main motivation is to avoid pytorch pin update in OSS after updating XNNPACKQuantizer, which can be rather frequent. Other impact and considerations: - PT2e flow (which lives in PyTorch) relies havily on XNNPACKQuantizer for a "example" implementation for quantizer and more importantly tests. Fow now, we will keep the torch.ao.quantization.xnnpack_quantizer as is but mark is as not BC, and deprecated to discourace future new dependencies on it. - Other OSS repository using XNNPACKQuantizer from PyTorch now have to take an additional dependency on ExecuTorch. Reviewed By: mcr229 Differential Revision: D68191752
digantdesai
force-pushed
the
export-D68191752
branch
from
3a19dbf to
528bac2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68191752 |
digantdesai
added a commit
to digantdesai/pytorch
that referenced
this pull request
Jan 22, 2025
Summary: X-link: pytorch/executorch#7804 Pull Request resolved: pytorch#144940 This migrates XNNPACKQuantizer from PyTorch to ExecuTorch. Rationale: Main motivation is to avoid pytorch pin update in OSS after updating XNNPACKQuantizer, which can be rather frequent. Other impact and considerations: - PT2e flow (which lives in PyTorch) relies havily on XNNPACKQuantizer for a "example" implementation for quantizer and more importantly tests. Fow now, we will keep the torch.ao.quantization.xnnpack_quantizer as is but mark is as not BC, and deprecated to discourace future new dependencies on it. - Other OSS repository using XNNPACKQuantizer from PyTorch now have to take an additional dependency on ExecuTorch. Test Plan: CI Reviewed By: mcr229 Differential Revision: D68191752
digantdesai
force-pushed
the
export-D68191752
branch
from
528bac2 to
ed9c084
Compare
digantdesai
added a commit
to digantdesai/executorch-1
that referenced
this pull request
Jan 23, 2025
Summary: Pull Request resolved: pytorch#7804 X-link: pytorch/pytorch#144940 This migrates XNNPACKQuantizer from PyTorch to ExecuTorch. Rationale: Main motivation is to avoid pytorch pin update in OSS after updating XNNPACKQuantizer, which can be rather frequent. Other impact and considerations: - PT2e flow (which lives in PyTorch) relies havily on XNNPACKQuantizer for a "example" implementation for quantizer and more importantly tests. Fow now, we will keep the torch.ao.quantization.xnnpack_quantizer as is but mark is as not BC, and deprecated to discourace future new dependencies on it. - Other OSS repository using XNNPACKQuantizer from PyTorch now have to take an additional dependency on ExecuTorch. Reviewed By: mcr229 Differential Revision: D68191752
|
This pull request was exported from Phabricator. Differential Revision: D68191752 |
digantdesai
added a commit
to digantdesai/pytorch
that referenced
this pull request
Jan 23, 2025
Summary: X-link: pytorch/executorch#7804 Pull Request resolved: pytorch#144940 This migrates XNNPACKQuantizer from PyTorch to ExecuTorch. Rationale: Main motivation is to avoid pytorch pin update in OSS after updating XNNPACKQuantizer, which can be rather frequent. Other impact and considerations: - PT2e flow (which lives in PyTorch) relies havily on XNNPACKQuantizer for a "example" implementation for quantizer and more importantly tests. Fow now, we will keep the torch.ao.quantization.xnnpack_quantizer as is but mark is as not BC, and deprecated to discourace future new dependencies on it. - Other OSS repository using XNNPACKQuantizer from PyTorch now have to take an additional dependency on ExecuTorch. Test Plan: CI Reviewed By: mcr229 Differential Revision: D68191752
digantdesai
added a commit
to digantdesai/executorch-1
that referenced
this pull request
Jan 23, 2025
Summary: Pull Request resolved: pytorch#7804 X-link: pytorch/pytorch#144940 This migrates XNNPACKQuantizer from PyTorch to ExecuTorch. Rationale: Main motivation is to avoid pytorch pin update in OSS after updating XNNPACKQuantizer, which can be rather frequent. Other impact and considerations: - PT2e flow (which lives in PyTorch) relies havily on XNNPACKQuantizer for a "example" implementation for quantizer and more importantly tests. Fow now, we will keep the torch.ao.quantization.xnnpack_quantizer as is but mark is as not BC, and deprecated to discourace future new dependencies on it. - Other OSS repository using XNNPACKQuantizer from PyTorch now have to take an additional dependency on ExecuTorch. Reviewed By: mcr229 Differential Revision: D68191752
digantdesai
added a commit
to digantdesai/executorch-1
that referenced
this pull request
Jan 23, 2025
Summary: Pull Request resolved: pytorch#7804 X-link: pytorch/pytorch#144940 This migrates XNNPACKQuantizer from PyTorch to ExecuTorch. Rationale: Main motivation is to avoid pytorch pin update in OSS after updating XNNPACKQuantizer, which can be rather frequent. Other impact and considerations: - PT2e flow (which lives in PyTorch) relies havily on XNNPACKQuantizer for a "example" implementation for quantizer and more importantly tests. Fow now, we will keep the torch.ao.quantization.xnnpack_quantizer as is but mark is as not BC, and deprecated to discourace future new dependencies on it. - Other OSS repository using XNNPACKQuantizer from PyTorch now have to take an additional dependency on ExecuTorch. Reviewed By: mcr229 Differential Revision: D68191752
digantdesai
force-pushed
the
export-D68191752
branch
from
456df9b to
0763f23
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68191752 |
digantdesai
force-pushed
the
export-D68191752
branch
from
0763f23 to
a9f3035
Compare
digantdesai
added a commit
to digantdesai/executorch-1
that referenced
this pull request
Jan 23, 2025
Summary: Pull Request resolved: pytorch#7804 X-link: pytorch/pytorch#144940 This migrates XNNPACKQuantizer from PyTorch to ExecuTorch. Rationale: Main motivation is to avoid pytorch pin update in OSS after updating XNNPACKQuantizer, which can be rather frequent. Other impact and considerations: - PT2e flow (which lives in PyTorch) relies havily on XNNPACKQuantizer for a "example" implementation for quantizer and more importantly tests. Fow now, we will keep the torch.ao.quantization.xnnpack_quantizer as is but mark is as not BC, and deprecated to discourace future new dependencies on it. - Other OSS repository using XNNPACKQuantizer from PyTorch now have to take an additional dependency on ExecuTorch. Reviewed By: mcr229 Differential Revision: D68191752
|
This pull request was exported from Phabricator. Differential Revision: D68191752 |
digantdesai
added a commit
to digantdesai/executorch-1
that referenced
this pull request
Jan 23, 2025
Summary: Pull Request resolved: pytorch#7804 X-link: pytorch/pytorch#144940 This migrates XNNPACKQuantizer from PyTorch to ExecuTorch. Rationale: Main motivation is to avoid pytorch pin update in OSS after updating XNNPACKQuantizer, which can be rather frequent. Other impact and considerations: - PT2e flow (which lives in PyTorch) relies havily on XNNPACKQuantizer for a "example" implementation for quantizer and more importantly tests. Fow now, we will keep the torch.ao.quantization.xnnpack_quantizer as is but mark is as not BC, and deprecated to discourace future new dependencies on it. - Other OSS repository using XNNPACKQuantizer from PyTorch now have to take an additional dependency on ExecuTorch. Reviewed By: mcr229 Differential Revision: D68191752
digantdesai
force-pushed
the
export-D68191752
branch
from
a9f3035 to
f7f214c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68191752 |
digantdesai
added a commit
to digantdesai/executorch-1
that referenced
this pull request
Jan 23, 2025
Summary: Pull Request resolved: pytorch#7804 X-link: pytorch/pytorch#144940 This migrates XNNPACKQuantizer from PyTorch to ExecuTorch. Rationale: Main motivation is to avoid pytorch pin update in OSS after updating XNNPACKQuantizer, which can be rather frequent. Other impact and considerations: - PT2e flow (which lives in PyTorch) relies havily on XNNPACKQuantizer for a "example" implementation for quantizer and more importantly tests. Fow now, we will keep the torch.ao.quantization.xnnpack_quantizer as is but mark is as not BC, and deprecated to discourace future new dependencies on it. - Other OSS repository using XNNPACKQuantizer from PyTorch now have to take an additional dependency on ExecuTorch. Reviewed By: mcr229 Differential Revision: D68191752
digantdesai
force-pushed
the
export-D68191752
branch
from
f7f214c to
20155a3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68191752 |
digantdesai
added a commit
to digantdesai/executorch-1
that referenced
this pull request
Jan 23, 2025
Summary: Pull Request resolved: pytorch#7804 X-link: pytorch/pytorch#144940 This migrates XNNPACKQuantizer from PyTorch to ExecuTorch. Rationale: Main motivation is to avoid pytorch pin update in OSS after updating XNNPACKQuantizer, which can be rather frequent. Other impact and considerations: - PT2e flow (which lives in PyTorch) relies havily on XNNPACKQuantizer for a "example" implementation for quantizer and more importantly tests. Fow now, we will keep the torch.ao.quantization.xnnpack_quantizer as is but mark is as not BC, and deprecated to discourace future new dependencies on it. - Other OSS repository using XNNPACKQuantizer from PyTorch now have to take an additional dependency on ExecuTorch. Reviewed By: mcr229 Differential Revision: D68191752
digantdesai
force-pushed
the
export-D68191752
branch
from
20155a3 to
7f1f5f3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68191752 |
digantdesai
added a commit
to digantdesai/executorch-1
that referenced
this pull request
Jan 23, 2025
Summary: Pull Request resolved: pytorch#7804 X-link: pytorch/pytorch#144940 This migrates XNNPACKQuantizer from PyTorch to ExecuTorch. Rationale: Main motivation is to avoid pytorch pin update in OSS after updating XNNPACKQuantizer, which can be rather frequent. Other impact and considerations: - PT2e flow (which lives in PyTorch) relies havily on XNNPACKQuantizer for a "example" implementation for quantizer and more importantly tests. Fow now, we will keep the torch.ao.quantization.xnnpack_quantizer as is but mark is as not BC, and deprecated to discourace future new dependencies on it. - Other OSS repository using XNNPACKQuantizer from PyTorch now have to take an additional dependency on ExecuTorch. Reviewed By: mcr229 Differential Revision: D68191752
digantdesai
force-pushed
the
export-D68191752
branch
from
7f1f5f3 to
13f7582
Compare
digantdesai
added a commit
to digantdesai/pytorch
that referenced
this pull request
Jan 23, 2025
Summary: X-link: pytorch/executorch#7804 Pull Request resolved: pytorch#144940 This migrates XNNPACKQuantizer from PyTorch to ExecuTorch. Rationale: Main motivation is to avoid pytorch pin update in OSS after updating XNNPACKQuantizer, which can be rather frequent. Other impact and considerations: - PT2e flow (which lives in PyTorch) relies havily on XNNPACKQuantizer for a "example" implementation for quantizer and more importantly tests. Fow now, we will keep the torch.ao.quantization.xnnpack_quantizer as is but mark is as not BC, and deprecated to discourace future new dependencies on it. - Other OSS repository using XNNPACKQuantizer from PyTorch now have to take an additional dependency on ExecuTorch. Test Plan: CI Reviewed By: mcr229 Differential Revision: D68191752
Summary: Pull Request resolved: pytorch#7804 X-link: pytorch/pytorch#144940 This migrates XNNPACKQuantizer from PyTorch to ExecuTorch. Rationale: Main motivation is to avoid pytorch pin update in OSS after updating XNNPACKQuantizer, which can be rather frequent. Other impact and considerations: - PT2e flow (which lives in PyTorch) relies havily on XNNPACKQuantizer for a "example" implementation for quantizer and more importantly tests. Fow now, we will keep the torch.ao.quantization.xnnpack_quantizer as is but mark is as not BC, and deprecated to discourace future new dependencies on it. - Other OSS repository using XNNPACKQuantizer from PyTorch now have to take an additional dependency on ExecuTorch. Reviewed By: mcr229 Differential Revision: D68191752
|
This pull request was exported from Phabricator. Differential Revision: D68191752 |
digantdesai
force-pushed
the
export-D68191752
branch
from
13f7582 to
67d64fe
Compare
digantdesai
added a commit
to digantdesai/pytorch
that referenced
this pull request
Jan 24, 2025
Summary: X-link: pytorch/executorch#7804 Pull Request resolved: pytorch#144940 This migrates XNNPACKQuantizer from PyTorch to ExecuTorch. Rationale: Main motivation is to avoid pytorch pin update in OSS after updating XNNPACKQuantizer, which can be rather frequent. Other impact and considerations: - PT2e flow (which lives in PyTorch) relies havily on XNNPACKQuantizer for a "example" implementation for quantizer and more importantly tests. Fow now, we will keep the torch.ao.quantization.xnnpack_quantizer as is but mark is as not BC, and deprecated to discourace future new dependencies on it. - Other OSS repository using XNNPACKQuantizer from PyTorch now have to take an additional dependency on ExecuTorch. Test Plan: CI Reviewed By: mcr229 Differential Revision: D68191752
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
Differential Revision: D68191752 Pull Request resolved: #7804
zonglinpeng
pushed a commit
to zonglinpeng/executorch
that referenced
this pull request
Jan 30, 2025
Differential Revision: D68191752 Pull Request resolved: pytorch#7804
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: pytorch/pytorch#144940
This migrates XNNPACKQuantizer from PyTorch to ExecuTorch.
Rationale:
Main motivation is to avoid pytorch pin update in OSS after updating XNNPACKQuantizer, which can be rather frequent.
Other impact and considerations:
PT2e flow (which lives in PyTorch) relies havily on XNNPACKQuantizer for a "example" implementation for quantizer and more importantly tests. Fow now, we will keep the torch.ao.quantization.xnnpack_quantizer as is but mark is as not BC, and deprecated to discourace future new dependencies on it.
Other OSS repository using XNNPACKQuantizer from PyTorch now have to take an additional dependency on ExecuTorch.
Differential Revision: D68191752