-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Closed
Labels
actionablemodule: cppRelated to C++ APIRelated to C++ APImodule: cpp-extensionsRelated to torch.utils.cpp_extensionRelated to torch.utils.cpp_extensiontriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
Description
🐛 Describe the bug
We use some functions in python_arg_parser.h for our backend and those symbols are gone after #136743. In python_arg_parsers.h, you will see inline implementation such as
inline at::Tensor PythonArgs::tensor(int i) {
if (args[i] && THPVariable_CheckExact(args[i])) {
return THPVariable_Unpack(args[i]);
}
return tensor_slow(i);
}so functions like tensor_slow needs to be exposed by tagging tensor_slow with TORCH_PYTHON_API. Alternatively, we can try to remove inline and move implementation in cpp file.
Versions
latest main branch can repro.
Metadata
Metadata
Assignees
Labels
actionablemodule: cppRelated to C++ APIRelated to C++ APImodule: cpp-extensionsRelated to torch.utils.cpp_extensionRelated to torch.utils.cpp_extensiontriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module