Add Half support for softmax and log_softmax on CPU #103315
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/103315
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 7cf7caf with merge base 2aaa7e5 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
added
the
module: cpu
jgong5
approved these changes
Jun 9, 2023
test/test_nn.py
Outdated
There was a problem hiding this comment.
why move it to a different place? It makes reviewing harder. :-)
There was a problem hiding this comment.
Because it can't use @dtypes in the original place.
CaoE
force-pushed
the
fp16_softmax
branch
2 times, most recently
from
0853fcb to
486b4b5
Compare
CaoE
force-pushed
the
fp16_softmax
branch
4 times, most recently
from
95ec717 to
26ec8a7
Compare
|
@mruberry Could you please review this PR ? |
|
@mikaylagawarecki Could you please review this PR ? Thanks. |
mikaylagawarecki
approved these changes
Sep 26, 2023
CaoE
force-pushed
the
fp16_softmax
branch
3 times, most recently
from
1cdc8ce to
33184a6
Compare
CaoE
added
ciflow/trunk
|
@pytorchbot merge |
CaoE
force-pushed
the
fp16_softmax
branch
13 times, most recently
from
6ebbe39 to
0801f2c
Compare
CaoE
force-pushed
the
fp16_softmax
branch
2 times, most recently
from
e2e7d3c to
f93f49d
Compare
Co-authored-by: mikaylagawarecki <mikaylagawarecki@gmail.com>
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
Add Half support for softmax and log_softmax on CPU. Note: This introduces a correctness issue with MPS pytorch#111416 and pytorch#111479. Pull Request resolved: pytorch#103315 Approved by: https://github.com/jgong5, https://github.com/mikaylagawarecki, https://github.com/malfet
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
Add Half support for softmax and log_softmax on CPU. Note: This introduces a correctness issue with MPS pytorch#111416 and pytorch#111479. Pull Request resolved: pytorch#103315 Approved by: https://github.com/jgong5, https://github.com/mikaylagawarecki, https://github.com/malfet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Half support for softmax and log_softmax on CPU.
Note: This introduces a correctness issue with MPS #111416 and #111479.
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @voznesenskym @penguinwu @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler @ngimel