KEMBAR78
add Half support for multinomial on CPU by CaoE · Pull Request #104178 · pytorch/pytorch · GitHub
Skip to content

add Half support for multinomial on CPU #104178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 17 commits into from
Closed

add Half support for multinomial on CPU #104178

wants to merge 17 commits into from

Conversation

@CaoE
Copy link
Collaborator

@CaoE CaoE commented Jun 26, 2023 •
edited by pytorch-bot bot
Loading

@CaoE CaoE mentioned this pull request Jun 26, 2023
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 26, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/104178

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 721de27 with merge base 93a9b13 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@CaoE CaoE mentioned this pull request Jun 26, 2023
Closed
CaoE added a commit that referenced this pull request Jun 26, 2023
@CaoE
add Half support for multinomial on CPU
044a045 
ghstack-source-id: 8aa5675
Pull Request resolved: #104178
@CaoE CaoE marked this pull request as draft June 26, 2023 07:55
CaoE added a commit that referenced this pull request Jul 4, 2023
@CaoE
add Half support for multinomial on CPU
d0868cb 
ghstack-source-id: f166f62
Pull Request resolved: #104178
CaoE added a commit that referenced this pull request Jul 4, 2023
@CaoE
Update base for Update on "add Half support for addcmul, addcdiv, cum…
181939d 
…sum, and topk on CPU"


Cherry-picked from #103319 for #104178.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
CaoE added a commit that referenced this pull request Jul 4, 2023
@CaoE
Update on "add Half support for addcmul, addcdiv, cumsum, and topk on…
c4959cc 
… CPU"


Cherry-picked from #103319 for #104178.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
@CaoE CaoE added module: cpu CPU specific problem (e.g., perf, algorithm) module: half Related to float16 half-precision floats ciflow/trunk Trigger trunk jobs on your pull request labels Jul 4, 2023
@CaoE
Update on "add Half support for multinomial on CPU"
8c42e37 
cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
CaoE added a commit that referenced this pull request Jul 7, 2023
@CaoE
Update base for Update on "add Half support for addcmul, addcdiv, cum…
ae52fa5 
…sum, and topk on CPU"


Cherry-picked from #103319 for #104178.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
CaoE added a commit that referenced this pull request Jul 7, 2023
@CaoE
Update on "add Half support for addcmul, addcdiv, cumsum, and topk on…
0a5f7ca 
… CPU"


Cherry-picked from #103319 for #104178.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
@CaoE
Update on "add Half support for multinomial on CPU"
b28ad14 
cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
CaoE added a commit that referenced this pull request Jul 7, 2023
@CaoE
Update base for Update on "add Half support for addcmul, addcdiv, cum…
735e12e 
…sum, and topk on CPU"


Cherry-picked from #103319 for #104178.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
CaoE added a commit that referenced this pull request Jul 7, 2023
@CaoE
Update on "add Half support for addcmul, addcdiv, cumsum, and topk on…
42d7894 
… CPU"


Cherry-picked from #103319 for #104178.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
@CaoE
Update on "add Half support for multinomial on CPU"
e199041 
cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
CaoE added a commit that referenced this pull request Jul 7, 2023
@CaoE
Update base for Update on "add Half support for addcmul, addcdiv, cum…
c21ba0f 
…sum, and topk on CPU"


Cherry-picked from #103319 for #104178.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
CaoE added a commit that referenced this pull request Jul 7, 2023
@CaoE
Update on "add Half support for addcmul, addcdiv, cumsum, and topk on…
6104682 
… CPU"


Cherry-picked from #103319 for #104178.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
@CaoE
Update on "add Half support for multinomial on CPU"
45b3083 
cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
CaoE added a commit that referenced this pull request Jul 7, 2023
@CaoE
Update base for Update on "add Half support for addcmul, addcdiv, cum…
fb26a9f 
…sum, and topk on CPU"


Cherry-picked from #103319 for #104178.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
CaoE added a commit that referenced this pull request Jul 7, 2023
@CaoE
Update on "add Half support for addcmul, addcdiv, cumsum, and topk on…
75c278a 
… CPU"


Cherry-picked from #103319 for #104178.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
CaoE added a commit that referenced this pull request Jul 7, 2023
@CaoE
add Half support for multinomial on CPU
c4c6275 
ghstack-source-id: 4c72e8a
Pull Request resolved: #104178
@CaoE
Update on "add Half support for multinomial on CPU"
4640cb4 
cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 voznesenskym penguinwu EikanWang Guobing-Chen zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8

[ghstack-poisoned]
CaoE added a commit that referenced this pull request Oct 16, 2023
@CaoE
Update base for Update on "add Half support for addcmul, addcdiv, cum…
137b6f9 
…sum, and topk on CPU"


Cherry-picked from #103319 for #104178.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
CaoE added a commit that referenced this pull request Oct 16, 2023
@CaoE
Update on "add Half support for addcmul, addcdiv, cumsum, and topk on…
9546969 
… CPU"


Cherry-picked from #103319 for #104178.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
CaoE added a commit that referenced this pull request Oct 16, 2023
@CaoE
add Half support for multinomial on CPU
bb2d92f 
ghstack-source-id: 68d177b
Pull Request resolved: #104178
@CaoE
Update on "add Half support for multinomial on CPU"
721de27 
cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 voznesenskym penguinwu EikanWang Guobing-Chen zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8

[ghstack-poisoned]
CaoE added a commit that referenced this pull request Oct 20, 2023
@CaoE
add Half support for multinomial on CPU
5d5ea7b 
ghstack-source-id: 0dc897b
Pull Request resolved: #104178
@CaoE
Copy link
Collaborator Author

CaoE commented Oct 20, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Approval needed from one of the following:
jfix71, sangongs, soumith, priyaramani, angelayi, ...

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@CaoE CaoE requested a review from cpuhrsch October 20, 2023 02:54
@CaoE
Copy link
Collaborator Author

CaoE commented Oct 20, 2023

@cpuhrsch Could you please review this PR ? Thank you.

@cpuhrsch
Copy link
Contributor

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@cpuhrsch cpuhrsch added release notes: nn release notes category topic: improvements topic category labels Oct 20, 2023
@cpuhrsch
Copy link
Contributor

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/CaoE/34/head branch October 24, 2023 14:23
@CaoE CaoE mentioned this pull request Oct 31, 2023
Closed
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
@CaoE @xuhancn
add Half support for multinomial on CPU (pytorch#104178)
52e03ee 
Pull Request resolved: pytorch#104178
Approved by: https://github.com/jgong5, https://github.com/kulinseth, https://github.com/cpuhrsch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kulinseth kulinseth kulinseth approved these changes

@cpuhrsch cpuhrsch cpuhrsch approved these changes

@jgong5 jgong5 jgong5 approved these changes

@mingfeima mingfeima Awaiting requested review from mingfeima

@mruberry mruberry Awaiting requested review from mruberry

@ngimel ngimel Awaiting requested review from ngimel

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpu CPU specific problem (e.g., perf, algorithm) module: half Related to float16 half-precision floats module: inductor open source release notes: nn release notes category topic: improvements topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@CaoE @pytorchmergebot @cpuhrsch @kulinseth @jgong5 @pytorchbot