Add Half support for range, logspace, logit, median, nanmedian, kthvalue, poisson, cummax, cummin, prod, cumprod, histc, logcumsumexp, vander, cross, aten2, logaddexp, logaddexp2, hypot, and nextafter on CPU #107764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107764
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 6fe7bf7 with merge base 64fd027 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
added
the
module: cpu
CaoE
added
module: half
CaoE
force-pushed
the
fp16_ops
branch
5 times, most recently
from
12e9b2e to
212f29a
Compare
CaoE
force-pushed
the
fp16_ops
branch
9 times, most recently
from
352e7b4 to
badb645
Compare
CaoE
force-pushed
the
fp16_ops
branch
7 times, most recently
from
db6daf0 to
0096ea0
Compare
CaoE
force-pushed
the
fp16_ops
branch
2 times, most recently
from
619bf41 to
facd4df
Compare
CaoE
force-pushed
the
fp16_ops
branch
3 times, most recently
from
b1cc5aa to
38abff4
Compare
CaoE
force-pushed
the
fp16_ops
branch
2 times, most recently
from
a8fe409 to
d5ae1be
Compare
CaoE
added
the
ciflow/periodic
jgong5
requested changes
Oct 21, 2023
test/test_binary_ufuncs.py
Outdated
| b_16 = b.to(dtype=lowp_dtype) | ||
| actual_16 = a_16.atan2(b_16) | ||
| self.assertEqual(actual_16, actual.to(dtype=lowp_dtype)) | ||
| self.assertEqual(expected, actual_16.view(-1), exact_dtype=False, rtol=0, atol=0.02) |
There was a problem hiding this comment.
you are not using the rtol and atol variables set previously?
There was a problem hiding this comment.
Thanks for your comments. Fixed it.
jgong5
approved these changes
Oct 23, 2023
CaoE
requested review from
BowenBao,
abock,
kulinseth,
mruberry,
ngimel,
thiagocrepaldi and
wschin
as code owners
|
@cpuhrsch Could you please review this PR ? Thank you. |
|
@CaoE - I know this might be annoying, but can we split this up a bit more? While the number of lines changed isn't high, the number of ops is. That'll make it harder to bisect if there's compounding issues. |
…lue, poisson, cummax, cummin, prod, cumprod, histc, logcumsumexp, vander, cross, aten2, logaddexp, logaddexp2, hypot, and nextafter on CPU
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Half support for range, logspace, logit, median, nanmedian, kthvalue, poisson, cummax, cummin, prod, cumprod, histc, logcumsumexp, vander, cross, aten2, logaddexp, logaddexp2, hypot, and nextafter on CPU.
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @voznesenskym @penguinwu @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler @Xia-Weiwen @ngimel