KEMBAR78
Add Half for aten2, logaddexp, logaddexp2, hypot, and nextafter on CPU by CaoE · Pull Request #112138 · pytorch/pytorch · GitHub
Skip to content

Conversation

@CaoE
Copy link
Collaborator

@CaoE CaoE commented Oct 26, 2023

Add Half for aten2, logaddexp, logaddexp2, hypot, and nextafter on CPU.

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 26, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112138

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5c5c911 with merge base 46a34e8 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: onnx torch.onnx related changes that should show up in the release notes labels Oct 26, 2023
@github-actions github-actions bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label Oct 26, 2023
@CaoE CaoE changed the title Add Half for aten2, logaddexp, logaddexp2, hypot, and nextafter on CPU Add Half for aten2, logaddexp, logaddexp2, hypot, median, nanmedian, and nextafter on CPU Oct 26, 2023
Copy link
Collaborator

@thiagocrepaldi thiagocrepaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test/onnx/test_op_consistency.py change LGTM

@cpuhrsch
Copy link
Contributor

@CaoE - Could I kindly ask you to prod me again to review this one after your other accepted PRs have merged?

@CaoE
Copy link
Collaborator Author

CaoE commented Oct 30, 2023

@cpuhrsch Of course, and thank you very much for your help.

@zou3519 zou3519 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 30, 2023
@CaoE CaoE added topic: improvements topic category release notes: intel release notes category labels Nov 1, 2023
@CaoE
Copy link
Collaborator Author

CaoE commented Nov 6, 2023

@cpuhrsch Other accepted PRs mentioned in #107764 have been merged. Could you please review this PR ? Thank you.

@CaoE CaoE changed the title Add Half for aten2, logaddexp, logaddexp2, hypot, median, nanmedian, and nextafter on CPU Add Half for aten2, logaddexp, logaddexp2, hypot, and nextafter on CPU Nov 6, 2023
@cpuhrsch
Copy link
Contributor

cpuhrsch commented Nov 6, 2023

@pytorchbot rebase

@cpuhrsch
Copy link
Contributor

cpuhrsch commented Nov 6, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Tried to rebase and push PR #112138, but it was already up to date. Try rebasing against main by issuing:
@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
pytorch#112138)

Add Half for aten2, logaddexp, logaddexp2, hypot, and nextafter on CPU.

Pull Request resolved: pytorch#112138
Approved by: https://github.com/cpuhrsch
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
pytorch#112138)

Add Half for aten2, logaddexp, logaddexp2, hypot, and nextafter on CPU.

Pull Request resolved: pytorch#112138
Approved by: https://github.com/cpuhrsch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpu CPU specific problem (e.g., perf, algorithm) module: half Related to float16 half-precision floats open source release notes: intel release notes category release notes: onnx torch.onnx related changes that should show up in the release notes topic: improvements topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants