KEMBAR78
Binary out-of-place ge.Scalar / eq.Scalar support for NT by jbschlosser · Pull Request #107892 · pytorch/pytorch · GitHub
Skip to content

Binary out-of-place ge.Scalar / eq.Scalar support for NT #107892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Binary out-of-place ge.Scalar / eq.Scalar support for NT #107892

wants to merge 2 commits into from

Conversation

@jbschlosser
Copy link
Contributor

@jbschlosser jbschlosser commented Aug 24, 2023 •
edited
Loading

This was referenced Aug 24, 2023
Closed
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 24, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107892

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit a10b182 with merge base 3e6da46 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Aug 24, 2023
Closed
Closed
@cpuhrsch
Copy link
Contributor

Nit: You could also add it to the list here: https://pytorch.org/docs/master/nested.html#supported-operations

@jbschlosser
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 25, 2023
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@jbschlosser jbschlosser added topic: improvements topic category release notes: nested tensor Changes that have a direct impact on nested tensors labels Aug 28, 2023
@jbschlosser
Copy link
Contributor Author

@pytorchbot merge -f "ignore spurious failures"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Aug 28, 2023
@jbschlosser @pytorchmergebot
Binary op support for (B, C, *, *) NT with (C, 1, 1) dense (#107890)
67371c7 
Pull Request resolved: #107890
Approved by: https://github.com/cpuhrsch
ghstack dependencies: #107891, #107892
@huydhn
Copy link
Contributor

huydhn commented Aug 30, 2023

@pytorchbot drci

(Please ignore this comment, I'm testing Dr.CI)

@facebook-github-bot facebook-github-bot deleted the gh/jbschlosser/90/head branch September 1, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpuhrsch cpuhrsch cpuhrsch approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: nested tensor Changes that have a direct impact on nested tensors topic: improvements topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jbschlosser @cpuhrsch @pytorchmergebot @huydhn