KEMBAR78
Add Opinfos for the Tensor overload of linspace/logspace by qqaatw · Pull Request #107958 · pytorch/pytorch · GitHub
Skip to content

Add Opinfos for the Tensor overload of linspace/logspace #107958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Add Opinfos for the Tensor overload of linspace/logspace #107958

wants to merge 4 commits into from

Conversation

@qqaatw
Copy link
Collaborator

@qqaatw qqaatw commented Aug 25, 2023 •
edited
Loading

@qqaatw qqaatw requested review from mruberry and ngimel as code owners August 25, 2023 13:14
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 25, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107958

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 5f60a5c with merge base e276d70 (image):

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: python_frontend python frontend release notes category label Aug 25, 2023
This was referenced Aug 25, 2023
Closed
Closed
@qqaatw qqaatw added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 25, 2023
@zou3519 zou3519 requested review from zou3519 and removed request for mruberry and ngimel August 30, 2023 16:04
@zou3519
Copy link
Contributor

zou3519 commented Aug 30, 2023

Probably just needs some expected failures?

@qqaatw
Copy link
Collaborator Author

qqaatw commented Aug 30, 2023

Probably just needs some expected failures?

These tests are passing in the second PR, so I think if we merge the stack all together everything should be fine? (Probably problematic if we want to revert the second PR only in the future.)

zou3519
zou3519 previously approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the PR must stand on its own. It's possible we could revert the next PR in the stack (if it ends up breaking FC) and we would like this PR to stay in, so we should add all the necessary expected failures in this PR.

@zou3519 zou3519 dismissed their stale review September 5, 2023 15:49

Sorry, meant this to be a comment, withholding approval until we get all tests passing on this PR.

@qqaatw qqaatw requested a review from zou3519 September 8, 2023 21:18
pytorchmergebot pushed a commit that referenced this pull request Sep 11, 2023
@qqaatw @pytorchmergebot
Introduce Tensor overload to linspace and logspace (#104889)
57e5239 
Pull Request resolved: #104889
Approved by: https://github.com/zou3519
ghstack dependencies: #107958
@pytorch pytorch deleted a comment from pytorchmergebot Sep 11, 2023
@pytorch pytorch deleted a comment from pytorchmergebot Sep 11, 2023
pytorchmergebot added a commit that referenced this pull request Sep 11, 2023
@pytorchmergebot
Revert "Introduce Tensor overload to linspace and logspace (#104889)"
a7f5abe 
This reverts commit 57e5239.

Reverted #104889 on behalf of https://github.com/clee2000 due to sorry have to revert this to revert #107958 ([comment](#104889 (comment)))
@clee2000
Copy link
Contributor

@pytorchbot revert -m "I think the newly added test test_mps.py::TestConsistencyCPU::test_output_match_logspace_tensor_overload_cpu_complex64 is broken, probably a landrace since the mergebase seems to be 21 days old https://hud.pytorch.org/pytorch/pytorch/commit/106e0a0ef19c8dad088fc1ec10d7d93d76409352 https://github.com/pytorch/pytorch/actions/runs/6149523234/job/16685849126" -c landrace

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@qqaatw your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Sep 11, 2023
@pytorchmergebot
Revert "Add Opinfos for the Tensor overload of linspace/logspace (#10…
e276d70 
…7958)"

This reverts commit 106e0a0.

Reverted #107958 on behalf of https://github.com/clee2000 due to I think the newly added test test_mps.py::TestConsistencyCPU::test_output_match_logspace_tensor_overload_cpu_complex64 is broken, probably a landrace since the mergebase seems to be 21 days old https://hud.pytorch.org/pytorch/pytorch/commit/106e0a0ef19c8dad088fc1ec10d7d93d76409352 https://github.com/pytorch/pytorch/actions/runs/6149523234/job/16685849126 ([comment](#107958 (comment)))
@qqaatw qqaatw reopened this Sep 11, 2023
@qqaatw
Copy link
Collaborator Author

qqaatw commented Sep 11, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Sep 11, 2023
@qqaatw @pytorchmergebot
Introduce Tensor overload to linspace and logspace (#104889)
b2cba43 
Pull Request resolved: #104889
Approved by: https://github.com/zou3519
ghstack dependencies: #107958
@facebook-github-bot facebook-github-bot deleted the gh/qqaatw/18/head branch September 15, 2023 14:23
pytorchmergebot pushed a commit that referenced this pull request Sep 26, 2023
@qqaatw @pytorchmergebot
[VMAP] Add linspace and logspace batch rules (#105451)
129f535 
Pull Request resolved: #105451
Approved by: https://github.com/zou3519
ghstack dependencies: #107958, #104889
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zou3519 zou3519 zou3519 approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: python_frontend python frontend release notes category Reverted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@qqaatw @zou3519 @clee2000 @pytorchmergebot @pytorchbot