KEMBAR78
Add AMP support to linalg.vecdot. by lezcano · Pull Request #108165 · pytorch/pytorch · GitHub
Skip to content

Add AMP support to linalg.vecdot. #108165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add AMP support to linalg.vecdot. #108165

wants to merge 3 commits into from

Conversation

@lezcano
Copy link
Collaborator

@lezcano lezcano commented Aug 29, 2023 •
edited by pytorch-bot bot
Loading

Stack from ghstack (oldest at bottom):

We follow the same rules as matmul.

Fixes #108127

cc @mcarilli @ptrblck @leslie-fang-intel @jgong5

@lezcano
Add AMP support to linalg.vecdot.
f286747 
We follow the same rules as matmul.

Fixes #108127

[ghstack-poisoned]
@lezcano lezcano requested review from albanD and peterbell10 August 29, 2023 17:12
@lezcano lezcano added the release notes: cuda release notes category label Aug 29, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 29, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108165

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit 1f1955a with merge base b7624fc (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

albanD
albanD approved these changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any testing for these?

@lezcano
Update on "Add AMP support to linalg.vecdot."
1ab96da 
We follow the same rules as matmul.

Fixes #108127

cc mcarilli ptrblck leslie-fang-intel jgong5

[ghstack-poisoned]
@lezcano
Copy link
Collaborator Author

lezcano commented Aug 29, 2023

We just have generic tests for CPU, not for GPU... Is it alright if I leave it like this?

@lezcano
Copy link
Collaborator Author

lezcano commented Aug 29, 2023

nvm, just found the test. Let me add that.

@lezcano
Update on "Add AMP support to linalg.vecdot."
1f1955a 
We follow the same rules as matmul.

Fixes #108127

cc mcarilli ptrblck leslie-fang-intel jgong5

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Aug 29, 2023
@lezcano
Add AMP support to linalg.vecdot.
6e706e4 
We follow the same rules as matmul.

Fixes #108127

ghstack-source-id: c151a53
Pull Request resolved: #108165
@lezcano
Copy link
Collaborator Author

lezcano commented Aug 29, 2023

The CPU tests are in test_autocast.py (fine) and the CUDA tests are in test_cuda.py...

@lezcano
Copy link
Collaborator Author

lezcano commented Aug 29, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 29, 2023
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) are pending/not yet run. The first few are:

  • EasyCLA

Dig deeper by viewing the pending checks on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@lezcano
Copy link
Collaborator Author

lezcano commented Aug 29, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/Lezcano/231/head branch September 2, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

@peterbell10 peterbell10 Awaiting requested review from peterbell10

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: amp (automated mixed precision) autocast open source release notes: cuda release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lezcano @pytorchmergebot @albanD @pytorchbot