KEMBAR78
Fix `full` on symbolic value. by ysiraichi · Pull Request #108166 · pytorch/pytorch · GitHub
Skip to content

Fix full on symbolic value. #108166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Fix full on symbolic value. #108166

wants to merge 4 commits into from

Conversation

@ysiraichi
Copy link
Collaborator

@ysiraichi ysiraichi commented Aug 29, 2023 •
edited by pytorch-bot bot
Loading

Stack from ghstack (oldest at bottom):

Fix: #108067

This PR adds checks for sympy.Expr when extracting the dtype from a value inside the
full lowering.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @ngimel @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov

@ysiraichi
Fix full on symbolic value.
d746cb8 
Fix: #108067

This PR adds checks for `sympy.Expr` when extracting the dtype from a value inside the
`full` lowering.

[ghstack-poisoned]
ysiraichi added a commit that referenced this pull request Aug 29, 2023
@ysiraichi
Fix full on symbolic value.
bd07439 
Fix: #108067

This PR adds checks for `sympy.Expr` when extracting the dtype from a value inside the
`full` lowering.

ghstack-source-id: 2b5395e
Pull Request resolved: #108166
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 29, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108166

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6d362c1 with merge base db63bf3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

peterbell10
peterbell10 reviewed Aug 29, 2023
View reviewed changes
Skylion007
Skylion007 reviewed Aug 30, 2023
View reviewed changes
lezcano
lezcano approved these changes Aug 31, 2023
View reviewed changes
@ysiraichi
Update on "Fix full on symbolic value."
1fc5325 
Fix: #108067

This PR adds checks for `sympy.Expr` when extracting the dtype from a value inside the
`full` lowering.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov

[ghstack-poisoned]
ysiraichi added a commit that referenced this pull request Aug 31, 2023
@ysiraichi
Fix full on symbolic value.
e465ab8 
Fix: #108067

This PR adds checks for `sympy.Expr` when extracting the dtype from a value inside the
`full` lowering.

ghstack-source-id: 0088c42
Pull Request resolved: #108166
@ysiraichi
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 31, 2023
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@ysiraichi
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x e465ab8823f8f3b02d8717d2ac4556af17101955 returned non-zero exit code 1

Auto-merging test/inductor/test_torchinductor_dynamic_shapes.py
CONFLICT (content): Merge conflict in test/inductor/test_torchinductor_dynamic_shapes.py
Auto-merging torch/_inductor/lowering.py
error: could not apply e465ab8823f... Fix `full` on symbolic value.
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
Details for Dev Infra team Raised by workflow job

@ysiraichi
Rebased. on "Fix full on symbolic value."
711856b 
Fix: #108067

This PR adds checks for `sympy.Expr` when extracting the dtype from a value inside the
`full` lowering.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov

[ghstack-poisoned]
ysiraichi added a commit that referenced this pull request Aug 31, 2023
@ysiraichi
Fix full on symbolic value.
5821db3 
Fix: #108067

This PR adds checks for `sympy.Expr` when extracting the dtype from a value inside the
`full` lowering.

ghstack-source-id: ba86bc9
Pull Request resolved: #108166
@ysiraichi
Rebased. on "Fix full on symbolic value."
6d362c1 
Fix: #108067

This PR adds checks for `sympy.Expr` when extracting the dtype from a value inside the
`full` lowering.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov

[ghstack-poisoned]
ysiraichi added a commit that referenced this pull request Sep 1, 2023
@ysiraichi
Fix full on symbolic value.
ec78563 
Fix: #108067

This PR adds checks for `sympy.Expr` when extracting the dtype from a value inside the
`full` lowering.

ghstack-source-id: 4ce2c93
Pull Request resolved: #108166
@ysiraichi
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/ysiraichi/81/head branch September 5, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 left review comments

@peterbell10 peterbell10 peterbell10 left review comments

@lezcano lezcano lezcano approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor open source release notes: inductor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ysiraichi @pytorchmergebot @Skylion007 @lezcano @peterbell10 @pytorchbot