Add reference for linalg.vecdot #108188
Closed
Add reference for linalg.vecdot #108188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was addressing #108127, but then I realised that vecdot is already CompositeImplicit. Pushing anyway as a short-and-sweet PR. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108188
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit edea752 with merge base b7624fc ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Was addressing #108127, but then I realised that vecdot is already CompositeImplicit. Pushing anyway as a short-and-sweet PR. [ghstack-poisoned]
peterbell10
approved these changes
Aug 29, 2023
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 31, 2023
Follow-up on #108127 (comment) Pull Request resolved: #108194 Approved by: https://github.com/peterbell10 ghstack dependencies: #108188
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Was addressing #108127, but
then I realised that vecdot is already CompositeImplicit. Pushing anyway
as a short-and-sweet PR.
cc @ezyang @mruberry @lezcano @peterbell10 @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @ipiszy @ngimel @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov