[inductor] Handle aten.full's dtype in the decomposition #108443
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the lowering we don't have `SymFloat` and `SymInt`, we just have `sympy.Expr` so it is impossible to accurately determine the expected dtype of a `full` call. For example, `sym_float(int_expr)` has `is_integer=True` but should be treated as a float. In the decomposition though, we can get this right. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108443
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7c5a6b2 with merge base 29f17e1 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
peterbell10
added a commit
to peterbell10/pytorch
that referenced
this pull request
Sep 1, 2023
In the lowering we don't have `SymFloat` and `SymInt`, we just have `sympy.Expr` so it is impossible to accurately determine the expected dtype of a `full` call. For example, `sym_float(int_expr)` has `is_integer=True` but should be treated as a float. In the decomposition though, we can get this right. ghstack-source-id: a5b8e32 Pull Request resolved: pytorch#108443
…ion" In the lowering we don't have `SymFloat` and `SymInt`, we just have `sympy.Expr` so it is impossible to accurately determine the expected dtype of a `full` call. For example, `sym_float(int_expr)` has `is_integer=True` but should be treated as a float. In the decomposition though, we can get this right. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov [ghstack-poisoned]
peterbell10
added a commit
that referenced
this pull request
Sep 1, 2023
In the lowering we don't have `SymFloat` and `SymInt`, we just have `sympy.Expr` so it is impossible to accurately determine the expected dtype of a `full` call. For example, `sym_float(int_expr)` has `is_integer=True` but should be treated as a float. In the decomposition though, we can get this right. ghstack-source-id: 828e98b Pull Request resolved: #108443
lezcano
approved these changes
Sep 1, 2023
No, the test case I've included fails with Yukio's PR because the sympy expression for |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
In the lowering we don't have
SymFloatandSymInt, we just havesympy.Exprso it is impossible to accurately determine the expected dtype of a
fullcall.For example,
sym_float(int_expr)hasis_integer=Truebut should be treatedas a float. In the decomposition though, we can get this right.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @ipiszy @ngimel @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov