[Decomposition] baddbmm #108534

salilsdesai · 2023-09-04T23:58:19Z

Summary:
Moving decomposition of baddbmm from _inductor/decomposition.py and include it in core_aten_decompositions

pytorch/torch/_inductor/decomposition.py

Line 203 in ff38c0e

def baddbmm(self, batch1, batch2, beta=1, alpha=1):

Test Plan: Phabricator + OSS Tests

Differential Revision: D48871741

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @voznesenskym @penguinwu @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @ngimel @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov

pytorch-bot · 2023-09-04T23:58:21Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108534

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 984d55f with merge base caf4376 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2023-09-04T23:58:30Z

This pull request was exported from Phabricator. Differential Revision: D48871741

facebook-github-bot · 2023-09-06T23:25:12Z

This pull request was exported from Phabricator. Differential Revision: D48871741

facebook-github-bot · 2023-09-06T23:26:04Z

This pull request was exported from Phabricator. Differential Revision: D48871741

Summary: Moving decomposition of baddbmm from _inductor/decomposition.py and include it in core_aten_decompositions https://github.com/pytorch/pytorch/blob/ff38c0e2f9cae35378553c38ccf7188007fed938/torch/_inductor/decomposition.py#L203 Test Plan: Phabricator + OSS Tests Differential Revision: D48871741

facebook-github-bot · 2023-09-14T20:27:28Z

This pull request was exported from Phabricator. Differential Revision: D48871741

Summary: Moving decomposition of baddbmm from _inductor/decomposition.py and include it in core_aten_decompositions https://github.com/pytorch/pytorch/blob/ff38c0e2f9cae35378553c38ccf7188007fed938/torch/_inductor/decomposition.py#L203 Test Plan: Phabricator + OSS Tests Differential Revision: D48871741

facebook-github-bot · 2023-09-14T20:27:43Z

This pull request was exported from Phabricator. Differential Revision: D48871741

facebook-github-bot · 2023-09-16T02:56:30Z

This pull request was exported from Phabricator. Differential Revision: D48871741

Summary: bypass-github-pytorch-ci-checks Pull Request resolved: pytorch#108534 Moving decomposition of baddbmm from _inductor/decomposition.py and include it in core_aten_decompositions https://github.com/pytorch/pytorch/blob/ff38c0e2f9cae35378553c38ccf7188007fed938/torch/_inductor/decomposition.py#L203 Test Plan: Phabricator + OSS Tests Differential Revision: D48871741 fbshipit-source-id: 85803ec0e530be5b7a710deb419d05402c48f9bb

facebook-github-bot · 2023-09-17T18:47:33Z

This pull request was exported from Phabricator. Differential Revision: D48871741

facebook-github-bot · 2023-09-17T18:52:29Z

This pull request was exported from Phabricator. Differential Revision: D48871741

facebook-github-bot · 2023-09-17T19:19:26Z

This pull request was exported from Phabricator. Differential Revision: D48871741

peterbell10 · 2023-09-19T15:18:59Z

torch/testing/_internal/common_methods_invocations.py

You're missing opmath type promotion which wasn't necessary in inductor because it does those promotions to float32 implicitly.

@pw_cast_for_opmath should help, right?

SherlockNoMad · 2023-09-19T16:47:09Z

torch/_decomp/decompositions.py

add

@out_wrapper() @pw_cast_for_opmath

SherlockNoMad

per comment.

facebook-github-bot · 2023-09-19T17:23:33Z

This pull request was exported from Phabricator. Differential Revision: D48871741

facebook-github-bot · 2023-09-19T17:29:59Z

This pull request was exported from Phabricator. Differential Revision: D48871741

facebook-github-bot · 2023-09-19T17:58:27Z

This pull request was exported from Phabricator. Differential Revision: D48871741

Summary: bypass-github-pytorch-ci-checks Pull Request resolved: pytorch#108534 Moving decomposition of baddbmm from _inductor/decomposition.py and include it in core_aten_decompositions https://github.com/pytorch/pytorch/blob/ff38c0e2f9cae35378553c38ccf7188007fed938/torch/_inductor/decomposition.py#L203 Test Plan: Phabricator + OSS Tests Reviewed By: SS-JIA Differential Revision: D48871741 fbshipit-source-id: d7e2921112a0b333a389693cd45f33742a3f5b4c

facebook-github-bot · 2023-09-19T18:04:31Z

This pull request was exported from Phabricator. Differential Revision: D48871741

facebook-github-bot · 2023-09-20T12:45:37Z

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorchmergebot · 2023-09-20T12:49:27Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

peterbell10 · 2023-09-20T13:37:38Z

torch/_decomp/decompositions.py


+@out_wrapper()
+@pw_cast_for_opmath
+@register_decomposition([aten.baddbmm])


You're registering the decomposition before applying the pw_cast_for_opmath wrapper. This PR shouldn't have been merged with the tests still skipped.

facebook-github-bot added the fb-exported label Sep 4, 2023

github-actions bot added module: inductor ciflow/inductor labels Sep 4, 2023

salilsdesai force-pushed the export-D48871741 branch from a736cd3 to a8fc2d4 Compare September 6, 2023 23:25

salilsdesai force-pushed the export-D48871741 branch from a8fc2d4 to cbb0572 Compare September 6, 2023 23:26

salilsdesai force-pushed the export-D48871741 branch from cbb0572 to b675ca7 Compare September 14, 2023 20:27

salilsdesai force-pushed the export-D48871741 branch from b675ca7 to 07c52ce Compare September 14, 2023 20:27

salilsdesai force-pushed the export-D48871741 branch from 07c52ce to 2edb796 Compare September 16, 2023 02:56

salilsdesai requested review from mruberry and ngimel as code owners September 16, 2023 02:56

salilsdesai force-pushed the export-D48871741 branch from 2edb796 to 5c1a99a Compare September 17, 2023 18:47

salilsdesai force-pushed the export-D48871741 branch from 5c1a99a to f3a0218 Compare September 17, 2023 18:52

github-actions bot added the module: export label Sep 19, 2023

pytorch-bot bot added the ciflow/mps Run MPS tests (subset of trunk) label Sep 19, 2023

salilsdesai force-pushed the export-D48871741 branch from 1e619c1 to cc05ba8 Compare September 19, 2023 13:22

salilsdesai force-pushed the export-D48871741 branch from cc05ba8 to 9babd7c Compare September 19, 2023 13:29

peterbell10 reviewed Sep 19, 2023

View reviewed changes

SherlockNoMad reviewed Sep 19, 2023

View reviewed changes

torch/_decomp/decompositions.py Outdated

Copy link

Contributor

SherlockNoMad Sep 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add

@out_wrapper() @pw_cast_for_opmath

SherlockNoMad approved these changes Sep 19, 2023

View reviewed changes

salilsdesai force-pushed the export-D48871741 branch from 9babd7c to ad011fe Compare September 19, 2023 17:23

salilsdesai force-pushed the export-D48871741 branch from ad011fe to bff8083 Compare September 19, 2023 17:30

salilsdesai force-pushed the export-D48871741 branch from bff8083 to 8a694e8 Compare September 19, 2023 17:58

salilsdesai force-pushed the export-D48871741 branch from 8a694e8 to 984d55f Compare September 19, 2023 18:04

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 20, 2023

pytorchmergebot added the merging label Sep 20, 2023

pytorchmergebot added Merged and removed merging labels Sep 20, 2023

pytorchmergebot closed this in 40b2c79 Sep 20, 2023

peterbell10 reviewed Sep 20, 2023

View reviewed changes

[Decomposition] baddbmm #108534

[Decomposition] baddbmm #108534

Uh oh!

Conversation

salilsdesai commented Sep 4, 2023 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Sep 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108534

✅ No Failures

Uh oh!

facebook-github-bot commented Sep 4, 2023

Uh oh!

facebook-github-bot commented Sep 6, 2023

Uh oh!

facebook-github-bot commented Sep 6, 2023

Uh oh!

facebook-github-bot commented Sep 14, 2023

Uh oh!

facebook-github-bot commented Sep 14, 2023

Uh oh!

facebook-github-bot commented Sep 16, 2023

Uh oh!

facebook-github-bot commented Sep 17, 2023

Uh oh!

facebook-github-bot commented Sep 17, 2023

Uh oh!

facebook-github-bot commented Sep 17, 2023

Uh oh!

peterbell10 Sep 19, 2023

Choose a reason for hiding this comment

Uh oh!

SherlockNoMad Sep 19, 2023

Choose a reason for hiding this comment

Uh oh!

SherlockNoMad Sep 19, 2023

Choose a reason for hiding this comment

Uh oh!

SherlockNoMad left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Sep 19, 2023

Uh oh!

facebook-github-bot commented Sep 19, 2023

Uh oh!

facebook-github-bot commented Sep 19, 2023

Uh oh!

facebook-github-bot commented Sep 19, 2023

Uh oh!

facebook-github-bot commented Sep 20, 2023

Uh oh!

pytorchmergebot commented Sep 20, 2023

Merge started

Uh oh!

peterbell10 Sep 20, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

salilsdesai commented Sep 4, 2023 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Sep 4, 2023 •

edited

Loading