KEMBAR78
[Decomposition] unsafe_split.Tensor by salilsdesai · Pull Request #108544 · pytorch/pytorch · GitHub
Skip to content

[Decomposition] unsafe_split.Tensor #108544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Decomposition] unsafe_split.Tensor #108544

wants to merge 1 commit into from

Conversation

@salilsdesai
Copy link
Contributor

Summary:
Include decomp in core_aten_decompositions

Decomp already exists

https://www.internalfb.com/code/fbsource/[03ff511cad587fc27ed8fd6a54b87845246e8e0c]/fbcode/caffe2/torch/_decomp/decompositions.py?lines=1209

Test Plan: OSS + Phabricator Tests

Differential Revision: D48940445

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 5, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108544

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (8 Unrelated Failures)

As of commit f6cbddb with merge base 75b954b (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48940445

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48940445

salilsdesai added a commit to salilsdesai/pytorch that referenced this pull request Sep 7, 2023
@salilsdesai @facebook-github-bot
[Decomposition] unsafe_split.Tensor (pytorch#108544)
b129ee8 
Summary:

Include decomp in core_aten_decompositions

Decomp already exists

https://www.internalfb.com/code/fbsource/[03ff511cad587fc27ed8fd6a54b87845246e8e0c]/fbcode/caffe2/torch/_decomp/decompositions.py?lines=1209

Test Plan: OSS + Phabricator Tests

Differential Revision: D48940445
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48940445

larryliu0820
larryliu0820 approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@larryliu0820 larryliu0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit

salilsdesai added a commit to salilsdesai/pytorch that referenced this pull request Sep 14, 2023
@salilsdesai @facebook-github-bot
[Decomposition] unsafe_split.Tensor (pytorch#108544)
7f9d0d6 
Summary:

Include decomp in core_aten_decompositions

Decomp already exists

https://www.internalfb.com/code/fbsource/[03ff511cad587fc27ed8fd6a54b87845246e8e0c]/fbcode/caffe2/torch/_decomp/decompositions.py?lines=1209

Test Plan: OSS + Phabricator Tests

Differential Revision: D48940445
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48940445

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48940445

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48940445

salilsdesai added a commit to salilsdesai/pytorch that referenced this pull request Sep 15, 2023
@salilsdesai @facebook-github-bot
[Decomposition] unsafe_split.Tensor (pytorch#108544)
7789da7 
Summary:

Include decomp in core_aten_decompositions

Decomp already exists

https://www.internalfb.com/code/fbsource/[03ff511cad587fc27ed8fd6a54b87845246e8e0c]/fbcode/caffe2/torch/_decomp/decompositions.py?lines=1209

Test Plan: OSS + Phabricator Tests

Reviewed By: SS-JIA

Differential Revision: D48940445
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48940445

salilsdesai added a commit to salilsdesai/pytorch that referenced this pull request Sep 16, 2023
@salilsdesai @facebook-github-bot
[Decomposition] unsafe_split.Tensor (pytorch#108544)
62853ee 
Summary:
bypass-github-pytorch-ci-checks


Include decomp in core_aten_decompositions

Decomp already exists

https://www.internalfb.com/code/fbsource/[03ff511cad587fc27ed8fd6a54b87845246e8e0c]/fbcode/caffe2/torch/_decomp/decompositions.py?lines=1209

Test Plan: OSS + Phabricator Tests

Reviewed By: SS-JIA

Differential Revision: D48940445
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48940445

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48940445

@salilsdesai @facebook-github-bot
[Decomposition] unsafe_split.Tensor (pytorch#108544)
f6cbddb 
Summary:
bypass-github-pytorch-ci-checks


Include decomp in core_aten_decompositions

Decomp already exists

https://www.internalfb.com/code/fbsource/[03ff511cad587fc27ed8fd6a54b87845246e8e0c]/fbcode/caffe2/torch/_decomp/decompositions.py?lines=1209

Test Plan: OSS + Phabricator Tests

Reviewed By: SS-JIA

Differential Revision: D48940445
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48940445

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 18, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larryliu0820 larryliu0820 larryliu0820 approved these changes

@SherlockNoMad SherlockNoMad SherlockNoMad approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@salilsdesai @facebook-github-bot @pytorchmergebot @larryliu0820 @SherlockNoMad