Re-land: Break graph on `manual_seed`. #108647

ysiraichi · 2023-09-06T12:39:36Z

Stack from ghstack (oldest at bottom):

-> Re-land: Break graph on manual_seed. #108647

Trying to re-land #107594.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @ngimel @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov

Trying to re-land #108518. [ghstack-poisoned]

pytorch-bot · 2023-09-06T12:39:39Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108647

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7c5a6bc with merge base 3fe8417 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Trying to re-land #108518. ghstack-source-id: c8cfe27 Pull Request resolved: #108647

ysiraichi · 2023-09-07T10:21:38Z

@pytorchbot merge

pytorchmergebot · 2023-09-07T10:23:34Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

huydhn · 2023-09-08T21:15:37Z

@pytorchbot revert -m 'Ouch, we are hit again my another internal import error from https://github.com/pytorch/pytorch/blob/main/torch/_inductor/config.py#L205-L206' -c ghfirst

Check with @eellison and the suggestion is to revert instead. Here is the import error:

Test intersection with a plane behind a sphere.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/par_unpack.nsByOoGsX/arvr/projects/eye_tracking/Fringe/test/test_geometry.py", line 23, in setUp
    torch.random.manual_seed(random_seed)
  File "/tmp/par_unpack.nsByOoGsX/torch/_compile.py", line 22, in inner
    import torch._dynamo
  File "/tmp/par_unpack.nsByOoGsX/torch/_dynamo/__init__.py", line 2, in <module>
    from . import allowed_functions, convert_frame, eval_frame, resume_execution
  File "/tmp/par_unpack.nsByOoGsX/torch/_dynamo/convert_frame.py", line 40, in <module>
    from .eval_frame import always_optimize_code_objects, skip_code, TorchPatcher
  File "/tmp/par_unpack.nsByOoGsX/torch/_dynamo/eval_frame.py", line 61, in <module>
    from . import config, convert_frame, external_utils, skipfiles, utils
  File "/tmp/par_unpack.nsByOoGsX/torch/_dynamo/skipfiles.py", line 180, in <module>
    is_fbcode = importlib.import_module("torch._inductor.config").is_fbcode()
  File "/usr/local/fbcode/platform010/lib/python3.8/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "/tmp/par_unpack.nsByOoGsX/torch/_inductor/config.py", line 203, in <module>
    from libfb.py import parutil  # type: ignore[import]
ModuleNotFoundError: No module named 'libfb'

----------------------------------------------------------------------
Ran 1 test in 0.143s

pytorchmergebot · 2023-09-08T21:17:54Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot · 2023-09-08T21:18:05Z

@ysiraichi your PR has been successfully reverted.

This reverts commit c887309. Reverted #108647 on behalf of https://github.com/huydhn due to Ouch, we are hit again my another internal import error from https://github.com/pytorch/pytorch/blob/main/torch/_inductor/config.py#L205-L206 ([comment](#108647 (comment)))

eellison · 2023-09-08T21:24:11Z

Sorry for the revert. This is getting reverted because it's causing torch.manual_seed to have a dependency on torch._dynamo. We should figure out another way to graph break without adding the dependency cc @anijain2305

ysiraichi · 2023-09-11T13:58:58Z

@eellison @anijain2305 I guess we could just remove the disable_dynamo decorator. Dynamo is able to trace through manual_seed function. It does graph-break twice, though. What do you think?

These no longer fail with TEST_WITH_TORCHINDUCTOR. Pull Request resolved: #108674 Approved by: https://github.com/desertfire

This reverts commit ab9fb03. Reverted #108674 on behalf of https://github.com/huydhn due to Sorry for picking this up a bit late, but with #108647 reverted, these tests are failing again. So we need to wait for the PR to reland before we can land this change ([comment](#108674 (comment)))

Re-landing: #108647 (old #107594) [ghstack-poisoned]