[pytorch-vulkan] add aten::randn_like & aten::normal_ #109075

tina134 · 2023-09-11T22:53:49Z

Summary:
Implemented aten::normal_ shader and used it to create aten::randn_like.

Ops defintions:
https://pytorch.org/docs/stable/generated/torch.randn_like.html
https://pytorch.org/docs/stable/generated/torch.Tensor.normal_.html

Test Plan:

[ttingchulin@53491.od /data/sandcastle/boxes/fbsource (randn)]$ LD_LIBRARY_PATH=third-party/swiftshader/lib/linux-x64/ buck run fbcode/mode/dev-nosan //xplat/caffe2:pt_vulkan_api_test_bin  -- --gtest_filter="*<test>*" eg.  -- --gtest_filter="*randn_like*"

[==========] Running 2 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 2 tests from VulkanAPITest
[ RUN      ] VulkanAPITest.randn_like
[       OK ] VulkanAPITest.randn_like (230 ms)
[ RUN      ] VulkanAPITest.randn_like_large
[       OK ] VulkanAPITest.randn_like_large (570 ms)
[----------] 2 tests from VulkanAPITest (801 ms total)

[----------] Global test environment tear-down
[==========] 2 tests from 1 test suite ran. (801 ms total)
[  PASSED  ] 2 tests.

[ttingchulin@53491.od /data/sandcastle/boxes/fbsource (randn)]$ LD_LIBRARY_PATH=third-party/swiftshader/lib/linux-x64/ buck run fbcode/mode/dev-nosan //xplat/caffe2:pt_vulkan_api_test_bin  -- --gtest_filter="*<test>*" eg.  -- --gtest_filter="*normal_*"
[==========] Running 3 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 3 tests from VulkanAPITest
[ RUN      ] VulkanAPITest.normal_
[       OK ] VulkanAPITest.normal_ (222 ms)
[ RUN      ] VulkanAPITest.normal_large
[       OK ] VulkanAPITest.normal_large (136 ms)
[ RUN      ] VulkanAPITest.normal_error
[       OK ] VulkanAPITest.normal_error (37 ms)
[----------] 3 tests from VulkanAPITest (396 ms total)

[----------] Global test environment tear-down
[==========] 3 tests f.

Reviewed By: yipjustin

Differential Revision: D48814024

pytorch-bot · 2023-09-11T22:53:52Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/109075

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 3 Unrelated Failures

As of commit 3d861cf with merge base b01b934 ():

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

linux-foundation-easycla · 2023-09-11T22:53:53Z

The committers listed above are authorized under a signed CLA.

✅ login: tina134 (3d861cf)

facebook-github-bot · 2023-09-11T22:54:01Z

This pull request was exported from Phabricator. Differential Revision: D48814024

Summary: Implemented `aten::normal_` shader and used it to create `aten::randn_like`. Ops defintions: https://pytorch.org/docs/stable/generated/torch.randn_like.html https://pytorch.org/docs/stable/generated/torch.Tensor.normal_.html Test Plan: ``` [ttingchulin@53491.od /data/sandcastle/boxes/fbsource (randn)]$ LD_LIBRARY_PATH=third-party/swiftshader/lib/linux-x64/ buck run fbcode/mode/dev-nosan //xplat/caffe2:pt_vulkan_api_test_bin -- --gtest_filter="*<test>*" eg. -- --gtest_filter="*randn_like*" [==========] Running 2 tests from 1 test suite. [----------] Global test environment set-up. [----------] 2 tests from VulkanAPITest [ RUN ] VulkanAPITest.randn_like [ OK ] VulkanAPITest.randn_like (230 ms) [ RUN ] VulkanAPITest.randn_like_large [ OK ] VulkanAPITest.randn_like_large (570 ms) [----------] 2 tests from VulkanAPITest (801 ms total) [----------] Global test environment tear-down [==========] 2 tests from 1 test suite ran. (801 ms total) [ PASSED ] 2 tests. [ttingchulin@53491.od /data/sandcastle/boxes/fbsource (randn)]$ LD_LIBRARY_PATH=third-party/swiftshader/lib/linux-x64/ buck run fbcode/mode/dev-nosan //xplat/caffe2:pt_vulkan_api_test_bin -- --gtest_filter="*<test>*" eg. -- --gtest_filter="*normal_*" [==========] Running 3 tests from 1 test suite. [----------] Global test environment set-up. [----------] 3 tests from VulkanAPITest [ RUN ] VulkanAPITest.normal_ [ OK ] VulkanAPITest.normal_ (222 ms) [ RUN ] VulkanAPITest.normal_large [ OK ] VulkanAPITest.normal_large (136 ms) [ RUN ] VulkanAPITest.normal_error [ OK ] VulkanAPITest.normal_error (37 ms) [----------] 3 tests from VulkanAPITest (396 ms total) [----------] Global test environment tear-down [==========] 3 tests f. ``` Reviewed By: yipjustin Differential Revision: D48814024

facebook-github-bot · 2023-09-11T23:06:31Z

This pull request was exported from Phabricator. Differential Revision: D48814024

Summary: Implemented `aten::normal_` shader and used it to create `aten::randn_like`. Ops defintions: https://pytorch.org/docs/stable/generated/torch.randn_like.html https://pytorch.org/docs/stable/generated/torch.Tensor.normal_.html Test Plan: ``` [ttingchulin@53491.od /data/sandcastle/boxes/fbsource (randn)]$ LD_LIBRARY_PATH=third-party/swiftshader/lib/linux-x64/ buck run fbcode/mode/dev-nosan //xplat/caffe2:pt_vulkan_api_test_bin -- --gtest_filter="*<test>*" eg. -- --gtest_filter="*randn_like*" [==========] Running 2 tests from 1 test suite. [----------] Global test environment set-up. [----------] 2 tests from VulkanAPITest [ RUN ] VulkanAPITest.randn_like [ OK ] VulkanAPITest.randn_like (230 ms) [ RUN ] VulkanAPITest.randn_like_large [ OK ] VulkanAPITest.randn_like_large (570 ms) [----------] 2 tests from VulkanAPITest (801 ms total) [----------] Global test environment tear-down [==========] 2 tests from 1 test suite ran. (801 ms total) [ PASSED ] 2 tests. [ttingchulin@53491.od /data/sandcastle/boxes/fbsource (randn)]$ LD_LIBRARY_PATH=third-party/swiftshader/lib/linux-x64/ buck run fbcode/mode/dev-nosan //xplat/caffe2:pt_vulkan_api_test_bin -- --gtest_filter="*<test>*" eg. -- --gtest_filter="*normal_*" [==========] Running 3 tests from 1 test suite. [----------] Global test environment set-up. [----------] 3 tests from VulkanAPITest [ RUN ] VulkanAPITest.normal_ [ OK ] VulkanAPITest.normal_ (222 ms) [ RUN ] VulkanAPITest.normal_large [ OK ] VulkanAPITest.normal_large (136 ms) [ RUN ] VulkanAPITest.normal_error [ OK ] VulkanAPITest.normal_error (37 ms) [----------] 3 tests from VulkanAPITest (396 ms total) [----------] Global test environment tear-down [==========] 3 tests f. ``` Reviewed By: yipjustin Differential Revision: D48814024

facebook-github-bot · 2023-09-12T00:34:17Z

This pull request was exported from Phabricator. Differential Revision: D48814024

facebook-github-bot · 2023-09-12T20:14:25Z

This pull request was exported from Phabricator. Differential Revision: D48814024

facebook-github-bot · 2023-09-12T20:43:09Z

@tina134 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Summary: Implemented `aten::normal_` shader and used it to create `aten::randn_like`. Ops defintions: https://pytorch.org/docs/stable/generated/torch.randn_like.html https://pytorch.org/docs/stable/generated/torch.Tensor.normal_.html Test Plan: ``` [ttingchulin@53491.od /data/sandcastle/boxes/fbsource (randn)]$ LD_LIBRARY_PATH=third-party/swiftshader/lib/linux-x64/ buck run fbcode/mode/dev-nosan //xplat/caffe2:pt_vulkan_api_test_bin -- --gtest_filter="*<test>*" eg. -- --gtest_filter="*randn_like*" [==========] Running 2 tests from 1 test suite. [----------] Global test environment set-up. [----------] 2 tests from VulkanAPITest [ RUN ] VulkanAPITest.randn_like [ OK ] VulkanAPITest.randn_like (230 ms) [ RUN ] VulkanAPITest.randn_like_large [ OK ] VulkanAPITest.randn_like_large (570 ms) [----------] 2 tests from VulkanAPITest (801 ms total) [----------] Global test environment tear-down [==========] 2 tests from 1 test suite ran. (801 ms total) [ PASSED ] 2 tests. [ttingchulin@53491.od /data/sandcastle/boxes/fbsource (randn)]$ LD_LIBRARY_PATH=third-party/swiftshader/lib/linux-x64/ buck run fbcode/mode/dev-nosan //xplat/caffe2:pt_vulkan_api_test_bin -- --gtest_filter="*<test>*" eg. -- --gtest_filter="*normal_*" [==========] Running 3 tests from 1 test suite. [----------] Global test environment set-up. [----------] 3 tests from VulkanAPITest [ RUN ] VulkanAPITest.normal_ [ OK ] VulkanAPITest.normal_ (222 ms) [ RUN ] VulkanAPITest.normal_large [ OK ] VulkanAPITest.normal_large (136 ms) [ RUN ] VulkanAPITest.normal_error [ OK ] VulkanAPITest.normal_error (37 ms) [----------] 3 tests from VulkanAPITest (396 ms total) [----------] Global test environment tear-down [==========] 3 tests f. ``` Differential Revision: D48814024 Pulled By: tina134

facebook-github-bot · 2023-09-12T20:43:57Z

This pull request was exported from Phabricator. Differential Revision: D48814024

tina134 · 2023-09-12T23:26:36Z

/easycla

tina134 · 2023-09-12T23:42:06Z

/easycla

facebook-github-bot · 2023-09-13T01:05:03Z

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

pytorchmergebot · 2023-09-13T01:07:29Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

After #109075 Pull Request resolved: #109177 Approved by: https://github.com/angelayi

pytorch-bot bot added ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR module: vulkan release notes: vulkan release notes category labels Sep 11, 2023

facebook-github-bot added the fb-exported label Sep 11, 2023

tina134 requested a review from yipjustin September 11, 2023 23:04

tina134 force-pushed the export-D48814024 branch from ba6202d to eca92d5 Compare September 11, 2023 23:06

yipjustin approved these changes Sep 11, 2023

View reviewed changes

tina134 force-pushed the export-D48814024 branch from eca92d5 to 4b107b8 Compare September 12, 2023 00:34

tina134 force-pushed the export-D48814024 branch from 4b107b8 to 5234eb5 Compare September 12, 2023 20:14

tina134 force-pushed the export-D48814024 branch from 5234eb5 to 3d861cf Compare September 12, 2023 20:43

pytorchmergebot added merging Merged and removed merging labels Sep 13, 2023

pytorchmergebot closed this in a46df6e Sep 13, 2023

clee2000 mentioned this pull request Sep 13, 2023

Forward fix lint #109177

Closed

pytorchmergebot pushed a commit that referenced this pull request Sep 13, 2023

Forward fix lint (#109177)

015be4c

After #109075 Pull Request resolved: #109177 Approved by: https://github.com/angelayi

[pytorch-vulkan] add aten::randn_like & aten::normal_ #109075

[pytorch-vulkan] add aten::randn_like & aten::normal_ #109075

Uh oh!

Conversation

tina134 commented Sep 11, 2023

Uh oh!

pytorch-bot bot commented Sep 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/109075

❌ 3 New Failures, 3 Unrelated Failures

Uh oh!

linux-foundation-easycla bot commented Sep 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Sep 11, 2023

Uh oh!

facebook-github-bot commented Sep 11, 2023

Uh oh!

facebook-github-bot commented Sep 12, 2023

Uh oh!

facebook-github-bot commented Sep 12, 2023

Uh oh!

facebook-github-bot commented Sep 12, 2023

Uh oh!

facebook-github-bot commented Sep 12, 2023

Uh oh!

tina134 commented Sep 12, 2023

Uh oh!

tina134 commented Sep 12, 2023

Uh oh!

facebook-github-bot commented Sep 13, 2023

Uh oh!

pytorchmergebot commented Sep 13, 2023

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pytorch-bot bot commented Sep 11, 2023 •

edited

Loading

linux-foundation-easycla bot commented Sep 11, 2023 •

edited

Loading