[FSDP][Wrap] ModuleWrapPolicy callable #109117
Conversation
Makes ModuleWrapPolicy callable, in my case this is needed for composition with or_policy. We should also make or_policy a public interface IMO. Differential Revision: [D49175112](https://our.internmc.facebook.com/intern/diff/D49175112/) [ghstack-poisoned]
rohan-varma
requested review from
H-Huang,
awgu,
d4l3k,
fduwjj,
fegin,
kiukchung,
kwen2501,
mrshenli,
wanchaol,
wz337 and
zhaojuanmao
as code owners
pytorch-bot
bot
added
the
release notes: distributed (fsdp)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/109117
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 42c32f4 with merge base b2cba43 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Makes ModuleWrapPolicy callable, in my case this is needed for composition with or_policy. We should also make or_policy a public interface IMO. Differential Revision: [D49175112](https://our.internmc.facebook.com/intern/diff/D49175112/) ghstack-source-id: 200376033 Pull Request resolved: #109117
Makes ModuleWrapPolicy callable, in my case this is needed for composition with or_policy. We should also make or_policy a public interface IMO. Differential Revision: [D49175112](https://our.internmc.facebook.com/intern/diff/D49175112/) [ghstack-poisoned]
|
@awgu is it OK for ModuleWrapPolicy? |
|
I think this is okay. I wonder if we should add a unit test though. |
Makes ModuleWrapPolicy callable, in my case this is needed for composition with or_policy. We should also make or_policy a public interface IMO. Differential Revision: [D49175112](https://our.internmc.facebook.com/intern/diff/D49175112/) [ghstack-poisoned]
Pull Request resolved: #109117 Makes ModuleWrapPolicy callable, in my case this is needed for composition with or_policy. We should also make or_policy a public interface IMO. ghstack-source-id: 200666498 @exported-using-ghexport Differential Revision: [D49175112](https://our.internmc.facebook.com/intern/diff/D49175112/)
|
That can be a good ramp up task: #109266 |
|
dynamo tests are unrelated |
|
@pytorchbot merge -f "CI done" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
4 participants
Stack from ghstack (oldest at bottom):
Makes ModuleWrapPolicy callable, in my case this is needed for
composition with or_policy. We should also make or_policy a public interface
IMO.
Differential Revision: D49175112