KEMBAR78
Back out "[AOTInductor] Include constants in AOTInductor .so file. (#108473)" by bertmaher · Pull Request #109243 · pytorch/pytorch · GitHub
Skip to content

Conversation

@bertmaher
Copy link
Contributor

@bertmaher bertmaher commented Sep 13, 2023

…108473)"

Original commit changeset: 9494d031e3ac

Original Phabricator Diff: D49075977

Differential Revision: [D49243049](https://our.internmc.facebook.com/intern/diff/D49243049/)

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 13, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/109243

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ae55a4d with merge base 916183a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Contributor

@mikekgfb mikekgfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR reverted by the present PR breaks CPU aot inductor

…so file. (#108473)""

Original commit changeset: 9494d031e3ac

Original Phabricator Diff: D49075977

Differential Revision: [D49243049](https://our.internmc.facebook.com/intern/diff/D49243049/)

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov

[ghstack-poisoned]
bertmaher added a commit that referenced this pull request Sep 13, 2023
…108473)"

Original commit changeset: 9494d031e3ac

Original Phabricator Diff: D49075977

Differential Revision: [D49243049](https://our.internmc.facebook.com/intern/diff/D49243049/)

ghstack-source-id: 6f57b61
Pull Request resolved: #109243
@bertmaher
Copy link
Contributor Author

We can't actually back this out, because the diff is important for a different production model. Argh. Fix forward, we shall.

@bertmaher bertmaher closed this Sep 14, 2023
@facebook-github-bot facebook-github-bot deleted the gh/bertmaher/194/head branch October 14, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants