KEMBAR78
[AOTInductor] Add is_cpu for AOTInductorModelContainer by muchulee8 · Pull Request #109287 · pytorch/pytorch · GitHub
Skip to content

[AOTInductor] Add is_cpu for AOTInductorModelContainer #109287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[AOTInductor] Add is_cpu for AOTInductorModelContainer #109287

wants to merge 1 commit into from

Conversation

@muchulee8
Copy link
Contributor

@muchulee8 muchulee8 commented Sep 14, 2023 •
edited
Loading

Summary:
If is_cpu is set for the model container, no need to move the weights from cpu to device.

Reviewed By: bertmaher

Differential Revision: D49252595

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 14, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/109287

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 34931b6 with merge base 7f7f626 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49252595

@github-actions
Copy link
Contributor

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49252595

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49252595

@muchulee8 @facebook-github-bot
[AOTInductor] Add is_cpu for AOTInductorModelContainer (pytorch#109287)
34931b6 
Summary:

If is_cpu is set for the model container, no need to move the weights from cpu to device.

Test Plan: fb: `buck run mode/dev-nosan scripts/bertrand/triton:slimdsnn -- aot --batch-size 5 --device cpu`

Reviewed By: mikekgfb

Differential Revision: D49252595
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49252595

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aakhundov aakhundov aakhundov approved these changes

Assignees

No one assigned

Labels

fb-exported Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@muchulee8 @facebook-github-bot @pytorchmergebot @aakhundov