KEMBAR78
Enable pickling model prepared with QAT qconfig by sindish · Pull Request #109288 · pytorch/pytorch · GitHub
Skip to content

Enable pickling model prepared with QAT qconfig #109288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Enable pickling model prepared with QAT qconfig #109288

wants to merge 1 commit into from

Conversation

@sindish
Copy link
Contributor

@sindish sindish commented Sep 14, 2023

Summary:
Resolving error:

AttributeError: Can't pickle local object '_add_module_to_qconfig_obs_ctr..get_factory_kwargs_based_on_module_device'

by moving nested function out to the main module

Test Plan: Added test to CI

Reviewed By: andrewor14

Differential Revision: D49187352

@sindish sindish requested a review from jerryzh168 as a code owner September 14, 2023 12:33
@pytorch-bot pytorch-bot bot added the release notes: quantization release notes category label Sep 14, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 14, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: sindish / name: Sindi Shkodrani (8834d05)

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 14, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/109288

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8834d05 with merge base d0f82cd (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49187352

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49187352

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49187352

@andrewor14 andrewor14 changed the title Unblock QAT multiprocessing Enable pickling model prepared with QAT qconfig Sep 25, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49187352

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49187352

@sindish
Copy link
Contributor Author

sindish commented Sep 26, 2023

/easycla

@sindish @facebook-github-bot
Enable pickling model prepared with QAT qconfig (pytorch#109288)
8834d05 
Summary:

Resolving error:

AttributeError: Can't pickle local object '_add_module_to_qconfig_obs_ctr.<locals>.get_factory_kwargs_based_on_module_device'

by moving nested function out to the main module

Test Plan: Added test to CI

Reviewed By: andrewor14

Differential Revision: D49187352
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49187352

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 28, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewor14 andrewor14 andrewor14 approved these changes

@jerryzh168 jerryzh168 Awaiting requested review from jerryzh168 jerryzh168 is a code owner

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged release notes: quantization release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sindish @facebook-github-bot @pytorchmergebot @andrewor14