KEMBAR78
Back out "Revert D49107540: [pytorch][PR] split by tag" by strisunshinewentingwang · Pull Request #109332 · pytorch/pytorch · GitHub
Skip to content

Back out "Revert D49107540: [pytorch][PR] split by tag" #109332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Back out "Revert D49107540: [pytorch][PR] split by tag" #109332

wants to merge 1 commit into from

Conversation

@strisunshinewentingwang
Copy link
Contributor

Summary:
Original commit changeset: 6391a068640b

Original Phabricator Diff: D49107540

Test Plan: same as D49107540

Differential Revision: D49297522

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 14, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/109332

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5adeac1 with merge base cc03e3a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: fx release notes category label Sep 14, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49297522

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49297522

@clee2000 clee2000 added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 15, 2023
clee2000
clee2000 reviewed Sep 15, 2023
View reviewed changes
test/fx/test_fx_split.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be using the TestCase imported from torch.testing._internal.common_utils, not unittest

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49297522

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49297522

strisunshinewentingwang pushed a commit to strisunshinewentingwang/pytorch that referenced this pull request Sep 15, 2023
@facebook-github-bot
Back out "Revert D49107540: [pytorch][PR] split by tag" (pytorch#109332)
41e6d69 
Summary:

Original commit changeset: 6391a068640b

Original Phabricator Diff: D49107540

https://fb.workplace.com/groups/1405155842844877/permalink/7432758670084534/

Test Plan: same as D49107540

Reviewed By: 842974287

Differential Revision: D49297522
@facebook-github-bot
Back out "Revert D49107540: [pytorch][PR] split by tag" (pytorch#109332)
5adeac1 
Summary:

Original commit changeset: 6391a068640b

Original Phabricator Diff: D49107540

bypass-github-pytorch-ci-checks


FB: https://fb.workplace.com/groups/1405155842844877/permalink/7432758670084534/

Test Plan: same as D49107540

Reviewed By: uciyc123, 842974287

Differential Revision: D49297522
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49297522

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clee2000 clee2000 clee2000 left review comments

@842974287 842974287 842974287 approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged release notes: fx release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@strisunshinewentingwang @facebook-github-bot @pytorchmergebot @842974287 @clee2000