KEMBAR78

[inductor] Add a C shim layer for libtorch by desertfire · Pull Request #109391 · pytorch/pytorch · GitHub

[inductor] Add a C shim layer for libtorch #109391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

desertfire wants to merge 1 commit into pytorch:main from desertfire:export-D49302669

+933 −166

Contributor

desertfire commented Sep 15, 2023 •

edited by pytorch-bot bot

Loading

Summary:
This PR adds a limited C shim layer for libtorch. The ultimate goal is to ban any direct reference to aten/c10 data structures or functions, to avoid ABI breakage by providing stable C interfaces.

To make the review and landing easier, we broke the changes into several steps. In this PR (a combination of #109022 and #109351), we add C interfaces for certain libtorch functions and modify the wrapper codegen to generate calls to those interfaces. There are a few other items to be addressed in future PRs:

The AOTInductor runtime interface still takes lists of aten tensors as input and output
The interaction with ProxyExecutor (general fallback support) needs to move away from aten tensor
Remove all references to aten/c10 headers in the AOTInductor-generated code

Differential Revision: D49302669

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @ngimel @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov

pytorch-bot bot commented Sep 15, 2023 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/109391

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 7 Unrelated Failures

As of commit 25d5077 with merge base 55c19a3 ():

NEW FAILURE - The following job has failed:

win-vs2019-cpu-py3 / test (default, 1, 3, windows.4xlarge.nonephemeral) (gh)

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Contributor

facebook-github-bot commented Sep 15, 2023

This pull request was exported from Phabricator. Differential Revision: D49302669

facebook-github-bot added the fb-exported label

github-actions bot added module: inductor ciflow/inductor labels

desertfire added the topic: not user facing label

Contributor

facebook-github-bot commented Sep 15, 2023

This pull request was exported from Phabricator. Differential Revision: D49302669

desertfire requested a review from chenyang78

September 15, 2023 20:41

Contributor Author

desertfire commented Sep 15, 2023

A combination of #109022 and #109351. Both were approved. Need to land from fbcode, thus created this PR by exporting.

chenyang78 approved these changes

View reviewed changes

Contributor

chenyang78 left a comment

LGTM. Thanks!

Contributor

facebook-github-bot commented Sep 15, 2023

This pull request was exported from Phabricator. Differential Revision: D49302669

4 similar comments

Contributor

facebook-github-bot commented Sep 15, 2023

This pull request was exported from Phabricator. Differential Revision: D49302669

Contributor

facebook-github-bot commented Sep 16, 2023

This pull request was exported from Phabricator. Differential Revision: D49302669

Contributor

facebook-github-bot commented Sep 16, 2023

This pull request was exported from Phabricator. Differential Revision: D49302669

Contributor

facebook-github-bot commented Sep 16, 2023

This pull request was exported from Phabricator. Differential Revision: D49302669


          [inductor] Add a C shim layer for libtorch (#109391)

25d5077

Summary:

This PR adds a limited C shim layer for libtorch. The ultimate goal is to ban any direct reference to aten/c10 data structures or functions, to avoid ABI breakage by providing stable C interfaces.

To make the review and landing easier, we broke the changes into several steps. In this PR (a combination of #109022 and #109351), we add C interfaces for certain libtorch functions and modify the wrapper codegen to generate calls to those interfaces. There are a few other items to be addressed in future PRs:

* The AOTInductor runtime interface still takes lists of aten tensors as input and output
* The interaction with ProxyExecutor (general fallback support) needs to move away from aten tensor
* Remove all references to aten/c10 headers in the AOTInductor-generated code

Reviewed By: chenyang78

Differential Revision: D49302669

Contributor

facebook-github-bot commented Sep 16, 2023

This pull request was exported from Phabricator. Differential Revision: D49302669

1 similar comment

Contributor

facebook-github-bot commented Sep 16, 2023

This pull request was exported from Phabricator. Differential Revision: D49302669

Contributor

facebook-github-bot commented Sep 16, 2023

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorch-bot bot added the ciflow/trunk label

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Sep 16, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot added Merged and removed merging labels

pytorchmergebot closed this in

0f646b1

This was referenced Sep 16, 2023

[inductor] Add a C shim layer for libtorch #109022

Closed

[inductor] Support get_sizes and get_strides in C shim #109351

Closed

[inductor] Forward fix a windows test error #109449

Closed

desertfire added a commit that referenced this pull request


          [inductor] Forward fix a windows test error

e449b4d

Summary: forward fix a windows test error from #109391

[ghstack-poisoned]

desertfire added a commit that referenced this pull request


          [inductor] Forward fix a windows test error

8530a73

Summary: forward fix a windows test error from #109391

ghstack-source-id: c4d4378
Pull Request resolved: #109449

desertfire added a commit that referenced this pull request


          Update on "[inductor] Forward fix a windows test error"

ddb1b19

Summary: forward fix a windows test error from #109391

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov

[ghstack-poisoned]

desertfire added a commit that referenced this pull request


          Update on "[inductor] Forward fix a windows test error"

e6d94c5

Summary: forward fix a windows test error from #109391

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov

[ghstack-poisoned]

desertfire added a commit that referenced this pull request


          Update on "[inductor] Forward fix a windows test error"

0c65588

Summary: forward fix a windows test error from #109391

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov

[ghstack-poisoned]

desertfire added a commit that referenced this pull request


          Update on "[inductor] Forward fix a windows test error"

Summary: forward fix a windows test error from #109391

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov

[ghstack-poisoned]

desertfire added a commit that referenced this pull request


          Update on "[inductor] Forward fix a windows test error"

99720ae

Summary: forward fix a windows test error from #109391

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov

[ghstack-poisoned]

desertfire added a commit that referenced this pull request


          Update on "[inductor] Forward fix a windows test error"

19ea483

Summary: forward fix a windows test error from #109391

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov

[ghstack-poisoned]

desertfire added a commit that referenced this pull request


          [inductor] Forward fix a windows test error

b8f8375

Summary: forward fix a windows test error from #109391

ghstack-source-id: 25d8143
Pull Request resolved: #109449

desertfire added a commit that referenced this pull request


          Update on "[inductor] Forward fix a windows test error"

b45e791

Summary: forward fix a windows test error from #109391

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov

[ghstack-poisoned]

desertfire added a commit that referenced this pull request


          [inductor] Forward fix a windows test error

09626d4

Summary: forward fix a windows test error from #109391

ghstack-source-id: cf31775
Pull Request resolved: #109449

pytorchmergebot pushed a commit that referenced this pull request


          [inductor] Forward fix a windows test error (#109449)

c8e4e08

Summary: forward fix a windows test error from #109391

Pull Request resolved: #109449
Approved by: https://github.com/mikekgfb

SherlockNoMad mentioned this pull request

[AOTInductor] Fix aot_inductor/test:test_custom_ops #109660

Closed

SherlockNoMad added a commit to SherlockNoMad/pytorch that referenced this pull request


          [AOTInductor] Fix aot_inductor/test:test_custom_ops

80b9630

Summary: Fix aot_inductor/test:test_custom_ops, which was broken by pytorch#109391

Test Plan: buck2 run mode/dev-nosan //deeplearning/aot_inductor/test:test_custom_ops

Differential Revision: D49438928

pytorchmergebot pushed a commit that referenced this pull request


          [AOTInductor] Fix aot_inductor/test:test_custom_ops (#109660)

293205c

Summary: Fix aot_inductor/test:test_custom_ops, which was broken by #109391

Test Plan: buck2 run mode/dev-nosan //deeplearning/aot_inductor/test:test_custom_ops

Differential Revision: D49438928

Pull Request resolved: #109660
Approved by: https://github.com/desertfire, https://github.com/chenyang78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk fb-exported Merged module: inductor topic: not user facing