[inductor] Decompose torch.ops.quantized.embedding_bag_byte_unpack #109398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would be cleaner if we had support for u8->float32 views (bitcasts) in inductor, but it works for now. Differential Revision: [D49329910](https://our.internmc.facebook.com/intern/diff/D49329910/) [ghstack-poisoned]
bertmaher
added a commit
that referenced
this pull request
Sep 15, 2023
This would be cleaner if we had support for u8->float32 views (bitcasts) in inductor, but it works for now. Differential Revision: [D49329910](https://our.internmc.facebook.com/intern/diff/D49329910/) ghstack-source-id: 200903874 Pull Request resolved: #109398
hl475
approved these changes
Sep 15, 2023
jansel
approved these changes
Sep 16, 2023
jgong5
reviewed
Sep 18, 2023
…mbedding_bag_byte_unpack" This would be cleaner if we had support for u8->float32 views (bitcasts) in inductor, but it works for now. Differential Revision: [D49329910](https://our.internmc.facebook.com/intern/diff/D49329910/) cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov [ghstack-poisoned]
github-actions
bot
added
module: cpu
…ag_byte_unpack" This would be cleaner if we had support for u8->float32 views (bitcasts) in inductor, but it works for now. Differential Revision: [D49329910](https://our.internmc.facebook.com/intern/diff/D49329910/) cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 voznesenskym penguinwu EikanWang Guobing-Chen zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov [ghstack-poisoned]
bertmaher
added a commit
that referenced
this pull request
Sep 18, 2023
Pull Request resolved: #109398 This would be cleaner if we had support for u8->float32 views (bitcasts) in inductor, but it works for now. ghstack-source-id: 201054789 @exported-using-ghexport Differential Revision: [D49329910](https://our.internmc.facebook.com/intern/diff/D49329910/)
jgong5
approved these changes
Sep 19, 2023
|
I suspect the breakages are present on trunk (or whatever base rev ghstack chose for this PR) 🤷 |
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This would be cleaner if we had support for u8->float32 views
(bitcasts) in inductor, but it works for now.
Differential Revision: D49329910
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @voznesenskym @penguinwu @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @ngimel @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov