KEMBAR78
Have inductor tests call output_process_fn_grad by int3 · Pull Request #109416 · pytorch/pytorch · GitHub
Skip to content

Conversation

@int3
Copy link
Contributor

@int3 int3 commented Sep 16, 2023

This is similar to what's done in test_ops.py.

Fixes #109353.

[ghstack-poisoned]
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Sep 16, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 16, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/109416

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit bb35d18 with merge base cc03e3a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This is similar to what's done in test_ops.py.

Fixes #109353.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov

[ghstack-poisoned]
@int3 int3 requested review from eellison and lezcano September 16, 2023 02:57
@int3 int3 marked this pull request as ready for review September 16, 2023 02:58
Copy link
Collaborator

@lezcano lezcano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why weren't failing svd and the other linalg functions that use outptut_process_fn_grad...

pytorchmergebot pushed a commit that referenced this pull request Sep 16, 2023
…09417)

Despite what the comments say, they do not seem to segfault not cause
CUDA errors any more.

Pull Request resolved: #109417
Approved by: https://github.com/lezcano
ghstack dependencies: #109359, #109416
@facebook-github-bot facebook-github-bot deleted the gh/int3/24/head branch September 19, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants