KEMBAR78
[foreach] check for empty tensors before dispatching to MTA by janeyx99 · Pull Request #109550 · pytorch/pytorch · GitHub
Skip to content

[foreach] check for empty tensors before dispatching to MTA #109550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

[foreach] check for empty tensors before dispatching to MTA #109550

wants to merge 7 commits into from

Conversation

@janeyx99
Copy link
Contributor

@janeyx99 janeyx99 commented Sep 18, 2023 •
edited
Loading

@pytorch-bot pytorch-bot bot added the release notes: foreach_frontend release notes category label Sep 18, 2023
@janeyx99 janeyx99 mentioned this pull request Sep 18, 2023
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 18, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/109550

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures

As of commit 5018986 with merge base 70ca3ee (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

janeyx99 added a commit that referenced this pull request Sep 18, 2023
@janeyx99
[does not build] check for empty tensors
76e0a8e 
ghstack-source-id: 1485d81
Pull Request resolved: #109550
janeyx99 added a commit that referenced this pull request Sep 19, 2023
@janeyx99
[does not build] check for empty tensors
ed22d2d 
ghstack-source-id: 5fb2033
Pull Request resolved: #109550
@janeyx99 janeyx99 changed the title [does not build] check for empty tensors [foreach] check for empty tensors before dispatching to MTA Sep 19, 2023
@janeyx99 janeyx99 added the topic: bug fixes topic category label Sep 19, 2023
janeyx99 added a commit that referenced this pull request Sep 20, 2023
@janeyx99
[does not build] check for empty tensors
41181b5 
ghstack-source-id: 2c060e4
Pull Request resolved: #109550
janeyx99
janeyx99 commented Sep 20, 2023
View reviewed changes
aten/src/ATen/native/cuda/ForeachPointwiseOp.cu
auto scalars = convert_tensor_to_scalar_list(scalars_, input.size()); \
check_foreach_api_restrictions(input, tensors1, tensors2, scalars); \
std::pair<bool, bool> p = \
can_use_fast_route({input, tensors1, tensors2}, scalars); \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I've added scalars to the can_use_fast_route call here. I'm pretty sure this should have been added before but want to confirm with @crcrpar

janeyx99
janeyx99 commented Sep 21, 2023
View reviewed changes
janeyx99 added a commit that referenced this pull request Sep 21, 2023
@janeyx99
[does not build] check for empty tensors
0cbde91 
ghstack-source-id: 4125e95
Pull Request resolved: #109550
@janeyx99 janeyx99 mentioned this pull request Sep 21, 2023
Closed
@janeyx99 janeyx99 marked this pull request as draft September 21, 2023 16:01
@janeyx99
Copy link
Contributor Author

Marking this as draft as we target landing #109402 first.

@github-actions
Copy link
Contributor

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Nov 20, 2023
@janeyx99
Copy link
Contributor Author

This is no longer necessary and has now been fixed.

@janeyx99 janeyx99 closed this Nov 20, 2023
@facebook-github-bot facebook-github-bot deleted the gh/janeyx99/92/head branch December 21, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mruberry mruberry Awaiting requested review from mruberry

@ngimel ngimel Awaiting requested review from ngimel

Assignees

No one assigned

Labels

release notes: foreach_frontend release notes category Stale topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@janeyx99