-
Notifications
You must be signed in to change notification settings - Fork 25.7k
add back in unsafe view decomp #109663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add back in unsafe view decomp #109663
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/109663
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 25b6bed with merge base 518308a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This decomp makes pattern matching easier, and was only just excluded from decomp set. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot merge -f "not related to rocm, taking too long" |
|
The merge job was canceled. If you believe this is a mistake, then you can re trigger it through pytorch-bot. |
|
@pytorchbot merge -f "not related to rocm, taking too long" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Adds a Python Pretty Printer to the pattern matcher that serializes patterns as python. Generating our fuse attention patterns was taking 4 seconds of compile time, which will only get worse as we add more variants (which I will do in the rest of this stack). To write out patterns, build pytorch, then run `gen_attention_patterns.py`. Since there is a line limit for PRs i'm only including the _sdpa_pattern1 in this first diff. Pull Request resolved: #108894 Approved by: https://github.com/yanboliang ghstack dependencies: #109663
Serializes the remaining traced patterns. Pull Request resolved: #108917 Approved by: https://github.com/davidberard98 ghstack dependencies: #109663, #108894
aten.softmax will generate a different decomposition for fp16/bf16 and fp32 because when invoked in lower precision it will upcast the inputs to fp32 and then downcast after. This has been causing us to miss bf16 patterns. For example, Camembert improves 20% with this PR (as do I'm sure many other models). Pull Request resolved: #109142 Approved by: https://github.com/yanboliang ghstack dependencies: #109663, #108894, #108917
Adds a 3d pattern that improves perf of HF Whisper from 1.3 -> 4.1. We could be matching more generally on 3d, but i'll leave that for another pr. Thanks to @drisspg for helping me write the pattern. Pull Request resolved: #109156 Approved by: https://github.com/yanboliang ghstack dependencies: #109663, #108894, #108917, #109142
Stack from ghstack (oldest at bottom):
This decomp makes pattern matching easier, and was only just excluded from decomp set in #108713
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @ngimel @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov