KEMBAR78
[profiler] Show shapes for lists of tensors in chrome traces #109263 by YuqingJ · Pull Request #109751 · pytorch/pytorch · GitHub
Skip to content

[profiler] Show shapes for lists of tensors in chrome traces #109263 #109751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[profiler] Show shapes for lists of tensors in chrome traces #109263 #109751

wants to merge 1 commit into from

Conversation

@YuqingJ
Copy link
Contributor

@YuqingJ YuqingJ commented Sep 20, 2023

Summary:
#109263
Show the shape of tensorlist when the length is < 30.

Test Plan:
{F1097707985}
and unit tests

Reviewed By: davidberard98

Differential Revision: D49351902

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 20, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/109751

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f856169 with merge base 52e1478 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 20, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: YuqingJ / name: YuqingJ (f856169)

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49351902

@YuqingJ YuqingJ marked this pull request as draft September 20, 2023 23:16
@YuqingJ
Copy link
Contributor Author

YuqingJ commented Sep 20, 2023

/easycla

@YuqingJ YuqingJ added release notes: profiler release notes category topic: new features topic category labels Sep 20, 2023
@davidberard98 davidberard98 self-requested a review September 20, 2023 23:31
@YuqingJ
Copy link
Contributor Author

YuqingJ commented Sep 21, 2023

/easycla

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49351902

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49351902

@YuqingJ @facebook-github-bot
[profiler] Show shapes for lists of tensors in chrome traces pytorch#…
f856169 
…109263 (pytorch#109751)

Summary:

pytorch#109263
Show the shape of tensorlist when the length is < 30.

Test Plan:
{F1097707985}
and unit tests

Reviewed By: davidberard98

Differential Revision: D49351902
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49351902

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49351902

@YuqingJ YuqingJ marked this pull request as ready for review September 25, 2023 19:17
@davidberard98
Copy link
Contributor

/easycla

1 similar comment
@YuqingJ
Copy link
Contributor Author

YuqingJ commented Sep 25, 2023

/easycla

davidberard98
davidberard98 approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@davidberard98 davidberard98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@YuqingJ
Copy link
Contributor Author

YuqingJ commented Sep 25, 2023

@pytorchbot

@YuqingJ
Copy link
Contributor Author

YuqingJ commented Sep 25, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 25, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aaronenyeshi aaronenyeshi Awaiting requested review from aaronenyeshi

1 more reviewer

@davidberard98 davidberard98 davidberard98 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged release notes: profiler release notes category topic: new features topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@YuqingJ @facebook-github-bot @davidberard98 @pytorchmergebot