KEMBAR78
[quant] Enable quantization for wav2letter by jerryzh168 · Pull Request #109830 · pytorch/pytorch · GitHub
Skip to content

[quant] Enable quantization for wav2letter #109830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[quant] Enable quantization for wav2letter #109830

wants to merge 1 commit into from

Conversation

@jerryzh168
Copy link
Contributor

Summary:
Also added annotation support for conv1d_relu and conv1d in XNNPACKQuantizer, the quantized results still
matches fx quant path (didn't quantize conv1d) so tests are not disabled

Test Plan: with-proxy buck2 run executorch/examples/quantization:example -- -m=w2l --verify

Differential Revision: D49479546

@pytorch-bot pytorch-bot bot added the release notes: quantization release notes category label Sep 21, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 21, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/109830

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 1b471aa with merge base d796518 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49479546

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49479546

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49479546

@jerryzh168 jerryzh168 mentioned this pull request Sep 22, 2023
Closed
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49479546

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49479546

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49479546

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49479546

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49479546

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49479546

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49479546

@jerryzh168 jerryzh168 force-pushed the export-D49479546 branch 2 times, most recently from cbb6adc to b84c1a9 Compare September 27, 2023 19:34
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49479546

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49479546

@jerryzh168 @facebook-github-bot
[quant] Enable quantization for wav2letter (pytorch#109830)
1b471aa 
Summary:
X-link: pytorch/executorch#446


Also added annotation support for conv1d_relu and conv1d in XNNPACKQuantizer, the quantized results still
matches fx quant path (didn't quantize conv1d) so tests are not disabled

Test Plan: with-proxy buck2 run executorch/examples/quantization:example -- -m=w2l --verify

Reviewed By: kimishpatel

Differential Revision: D49479546
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49479546

@jerryzh168
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 28, 2023
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR has internal changes and must be landed via Phabricator

Details for Dev Infra team Raised by workflow job

@jerryzh168
Copy link
Contributor Author

@pytorchbot merge

@jerryzh168
Copy link
Contributor Author

some problems landing the diff in phabricator, so I unlinked it and I'll land this one first

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR has internal changes and must be landed via Phabricator

Details for Dev Infra team Raised by workflow job

@jerryzh168
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kimishpatel kimishpatel kimishpatel approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged release notes: quantization release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jerryzh168 @facebook-github-bot @pytorchmergebot @kimishpatel