KEMBAR78
[quant][pt2e] Add quant API re-entrant test by jerryzh168 · Pull Request #110125 · pytorch/pytorch · GitHub
Skip to content

[quant][pt2e] Add quant API re-entrant test #110125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[quant][pt2e] Add quant API re-entrant test #110125

wants to merge 3 commits into from

Conversation

@jerryzh168
Copy link
Contributor

@jerryzh168 jerryzh168 commented Sep 26, 2023 •
edited
Loading

Stack from ghstack (oldest at bottom):

Summary:
Add the test to make sure we can call the quantize API multiple times

Test Plan:
python test/test_quantization.py TestQuantizePT2E.test_reentrant

Reviewers:

Subscribers:

Tasks:

Tags:

@jerryzh168
[quant][pt2e] Add quant API re-entrant test
31a576d 
Summary:
Add the test to make sure we can call the quantize API multiple times

Test Plan:
python test/test_quantization.py TestQuantizePT2E.test_reentrant

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@jerryzh168 jerryzh168 mentioned this pull request Sep 26, 2023
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 26, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110125

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c20b62d with merge base ec5bbef (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@jerryzh168 jerryzh168 mentioned this pull request Sep 26, 2023
Closed
@pytorch-bot pytorch-bot bot added the release notes: quantization release notes category label Sep 26, 2023
jerryzh168 added a commit that referenced this pull request Sep 26, 2023
@jerryzh168
[quant][pt2e] Add quant API re-entrant test
fe36681 
Summary:
Add the test to make sure we can call the quantize API multiple times

Test Plan:
python test/test_quantization.py TestQuantizePT2E.test_reentrant

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 98cfc4c
Pull Request resolved: #110125
@jerryzh168
Update on "[quant][pt2e] Add quant API re-entrant test"
994691a 
Summary:
Add the test to make sure we can call the quantize API multiple times

Test Plan:
python test/test_quantization.py TestQuantizePT2E.test_reentrant

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Sep 27, 2023
@jerryzh168
[quant][pt2e] Add quant API re-entrant test
d9bbbb4 
Summary:
Add the test to make sure we can call the quantize API multiple times

Test Plan:
python test/test_quantization.py TestQuantizePT2E.test_reentrant

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: b29cf76
Pull Request resolved: #110125
@jerryzh168
Update on "[quant][pt2e] Add quant API re-entrant test"
c20b62d 
Summary:
Add the test to make sure we can call the quantize API multiple times

Test Plan:
python test/test_quantization.py TestQuantizePT2E.test_reentrant

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Sep 27, 2023
@jerryzh168
[quant][pt2e] Add quant API re-entrant test
e0233ff 
Summary:
Add the test to make sure we can call the quantize API multiple times

Test Plan:
python test/test_quantization.py TestQuantizePT2E.test_reentrant

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 5fc8b4f
Pull Request resolved: #110125
kimishpatel
kimishpatel approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@kimishpatel kimishpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these. Looks great. I presume it would break when we move conv2d quantization from source partition to node.target based.

Also maybe worth adding linear in the model mix because that likely will break it today.

@jerryzh168
Copy link
Contributor Author

Thanks for adding these. Looks great. I presume it would break when we move conv2d quantization from source partition to node.target based.

Also maybe worth adding linear in the model mix because that likely will break it today.

yeah I'll change the test when I refactor aten.conv2d quantization, and will need to add the None support in XNNPACKQuantizer at that time I think, will add this soon

@jerryzh168
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 28, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/jerryzh168/921/head branch October 2, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kimishpatel kimishpatel kimishpatel approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: quantization release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jerryzh168 @pytorchmergebot @kimishpatel