[foreach][BE] cleaning up MultiTensorApply.cuh #110228
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110228
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ec3782c with merge base 7f57373 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
janeyx99
added
release notes: foreach_frontend
drisspg
approved these changes
Sep 28, 2023
crcrpar
reviewed
Sep 29, 2023
Comment on lines
+160
to
+161
| const auto numel = tensor_lists[0][t].numel(); | ||
| const auto chunks = numel / kChunkSize + (numel % kChunkSize != 0); |
There was a problem hiding this comment.
numel is int64_t so chunks is also, right?
There was a problem hiding this comment.
numel is a size_t i believe? this change is to prevent overflow (even tho overflow is likely unlikely here)
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup edits to #109402 as suggested by @r-barnes
cc @crcrpar
Stack from ghstack (oldest at bottom):