KEMBAR78
[core IR][reland] Add `split.Tensor` and `unbind` decompositions to core ATen decomp table by SS-JIA · Pull Request #110323 · pytorch/pytorch · GitHub
Skip to content

[core IR][reland] Add split.Tensor and unbind decompositions to core ATen decomp table #110323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[core IR][reland] Add split.Tensor and unbind decompositions to core ATen decomp table #110323

wants to merge 1 commit into from

Conversation

@SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Sep 29, 2023 •
edited by pytorch-bot bot
Loading

Summary:
This is a reland of github PR #110102.

The original PR had to be unlanded due to internal CI failures. This diff applies some small fixes to the failing tests to adjust to the new decompositions.

Note that lift_fresh will not be decomposed for now, since it was found that constant propogation looks specifically for lift_fresh. Therefore decomposing lift_fresh will interfere with constant propogation during export.

Test Plan: Github CI and internal CI

Differential Revision: D49761321

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler @avikchaudhuri @gmagogsfm

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 29, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110323

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 1a70124 with merge base 28b3ff7 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49761321

@github-actions
Copy link
Contributor

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49761321

SS-JIA pushed a commit to SS-JIA/pytorch that referenced this pull request Oct 2, 2023
@facebook-github-bot
[core IR][reland] Add split.Tensor and unbind decompositions to c…
d5d57d8 
…ore ATen decomp table (pytorch#110323)

Summary:
X-link: pytorch/executorch#550


This is a reland of [github PR pytorch#110102]( pytorch#110102).

The original PR had to be unlanded due to internal CI failures. This diff applies some small fixes to the failing tests to adjust to the new decompositions.

Note that `lift_fresh` will not be decomposed for now, since it was found that [constant propogation looks specifically for `lift_fresh`](https://github.com/pytorch/pytorch/blob/main/torch/fx/experimental/proxy_tensor.py#L386). Therefore decomposing `lift_fresh` will interfere with constant propogation during export.

Test Plan: Github CI and internal CI

Differential Revision: D49761321
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49761321

@facebook-github-bot
[core IR][reland] Add split.Tensor and unbind decompositions to c…
1a70124 
…ore ATen decomp table (pytorch#110323)

Summary:
X-link: pytorch/executorch#550


This is a reland of [github PR pytorch#110102]( pytorch#110102).

The original PR had to be unlanded due to internal CI failures. This diff applies some small fixes to the failing tests to adjust to the new decompositions.

Note that `lift_fresh` will not be decomposed for now, since it was found that [constant propogation looks specifically for `lift_fresh`](https://github.com/pytorch/pytorch/blob/main/torch/fx/experimental/proxy_tensor.py#L386). Therefore decomposing `lift_fresh` will interfere with constant propogation during export.

Test Plan: Github CI and internal CI

Differential Revision: D49761321
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49761321

facebook-github-bot pushed a commit to pytorch/executorch that referenced this pull request Oct 3, 2023
@SS-JIA @facebook-github-bot
Add split.Tensor and unbind decompositions to core ATen decomp ta…
0b0f49e 
…ble (#550)

Summary:
Pull Request resolved: #550

X-link: pytorch/pytorch#110323

This is a reland of [github PR #110102]( pytorch/pytorch#110102).

The original PR had to be unlanded due to internal CI failures. This diff applies some small fixes to the failing tests to adjust to the new decompositions.

Note that `lift_fresh` will not be decomposed for now, since it was found that [constant propogation looks specifically for `lift_fresh`](https://github.com/pytorch/pytorch/blob/main/torch/fx/experimental/proxy_tensor.py#L386). Therefore decomposing `lift_fresh` will interfere with constant propogation during export.

Reviewed By: kirklandsign

Differential Revision: D49761321

fbshipit-source-id: 77e0f12f6c4144086b2c3dff1910bfc1cd674c7a
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 3, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jansel jansel jansel approved these changes

@lezcano lezcano Awaiting requested review from lezcano

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

@peterbell10 peterbell10 Awaiting requested review from peterbell10

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged module: inductor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SS-JIA @facebook-github-bot @pytorchmergebot @jansel