[pt2e][xnnpack_quantizer] add util function to convert scalars to attrs #110427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jerry provided a notebook solution for converting scalars to attrs so that they may be properly quantized: https://fburl.com/anp/kzz7tfn1 Adding this pass as a util function in xnnpack_quantizer_utils.py Differential Revision: [D49850150](https://our.internmc.facebook.com/intern/diff/D49850150/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110427
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 480549b with merge base b083058 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…lars to attrs" Jerry provided a notebook solution for converting scalars to attrs so that they may be properly quantized: https://fburl.com/anp/kzz7tfn1 Adding this pass as a util function in xnnpack_quantizer_utils.py Differential Revision: [D49850150](https://our.internmc.facebook.com/intern/diff/D49850150/) [ghstack-poisoned]
jerryzh168
approved these changes
Oct 3, 2023
|
please make sure to fix lint before landing |
…lars to attrs" Jerry provided a notebook solution for converting scalars to attrs so that they may be properly quantized: https://fburl.com/anp/kzz7tfn1 Adding this pass as a util function in xnnpack_quantizer_utils.py Differential Revision: [D49850150](https://our.internmc.facebook.com/intern/diff/D49850150/) [ghstack-poisoned]
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 4, 2023
Adding "mul" to list of partitions that are supported by the quantizer. This shows up in EDSR, where we still want to quantize the mul op Differential Revision: [D49850151](https://our.internmc.facebook.com/intern/diff/D49850151/) Pull Request resolved: #110428 Approved by: https://github.com/jerryzh168 ghstack dependencies: #110427
|
Can't merge closed PR #110427 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Jerry provided a notebook solution for converting scalars to attrs so that they may be properly quantized:
https://fburl.com/anp/kzz7tfn1
Adding this pass as a util function in xnnpack_quantizer_utils.py
Differential Revision: D49850150