Add batch decomposition for torch.unsafe_chunk #110862

guilhermeleobas · 2023-10-09T13:12:07Z

Stack from ghstack (oldest at bottom):

-> Add batch decomposition for torch.unsafe_chunk #110862

This updates the docs as well to show torch.unsafe_chunk. Should the unsafe_* functions should not appear in the docs?

[ghstack-poisoned]

pytorch-bot · 2023-10-09T13:12:10Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110862

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3068b1d with merge base f77b9bf ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ghstack-source-id: 7085acc Pull Request resolved: #110862

kshitij12345 · 2023-10-09T19:53:51Z

torch/testing/_internal/common_methods_invocations.py

+    OpInfo('unsafe_chunk',
+           dtypes=all_types_and_complex_and(torch.bool, torch.bfloat16, torch.float16, torch.chalf),
+           sample_inputs_func=sample_inputs_chunk,
+           check_batched_forward_grad=False,


gradcheck uses legacy vmap implementation for batched forward and unsafe_chunk uses unsafe_split which doesn't have a batching rule for legacy vmap. (unsafe_split OpInfo also sets this to False)

kshitij12345

LGTM! Thanks @guilhermeleobas

cc: @zou3519 for binding approval.

docs/source/torch.rst

zou3519

Please remove the mention from the docs, otherwise, this LGTM

This updates the docs as well to show `torch.unsafe_chunk`. Should the `unsafe_*` functions should not appear in the docs? [ghstack-poisoned]

ghstack-source-id: 1a0a345 Pull Request resolved: #110862

guilhermeleobas · 2023-10-26T15:02:08Z

@pytorchbot merge

pytorchmergebot · 2023-10-26T15:04:26Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

EasyCLA

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

guilhermeleobas · 2023-10-27T13:46:30Z

@pytorchbot merge

pytorchmergebot · 2023-10-27T13:49:35Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

EasyCLA

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

guilhermeleobas · 2023-10-27T14:54:32Z

@pytorchbot merge

pytorchmergebot · 2023-10-27T14:56:43Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

EasyCLA

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

This updates the docs as well to show `torch.unsafe_chunk`. Should the `unsafe_*` functions should not appear in the docs? [ghstack-poisoned]

ghstack-source-id: b873d23 Pull Request resolved: #110862

guilhermeleobas · 2023-10-31T00:34:58Z

@pytorchbot merge

pytorchmergebot · 2023-10-31T00:36:49Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

This updates the docs as well to show `torch.unsafe_chunk`. Should the `unsafe_*` functions should not appear in the docs? Pull Request resolved: pytorch#110862 Approved by: https://github.com/kshitij12345, https://github.com/zou3519

Add batch decomposition for torch.unsafe_chunk

86275ce

[ghstack-poisoned]

guilhermeleobas requested review from mruberry and ngimel as code owners October 9, 2023 13:12

guilhermeleobas added a commit that referenced this pull request Oct 9, 2023

Add batch decomposition for torch.unsafe_chunk

fda6927

ghstack-source-id: 7085acc Pull Request resolved: #110862

guilhermeleobas marked this pull request as draft October 9, 2023 13:13

guilhermeleobas mentioned this pull request Oct 9, 2023

Add batch decomposition for torch.unsafe_chunk #110742

Closed

pytorchbot added the open source label Oct 9, 2023

guilhermeleobas marked this pull request as ready for review October 9, 2023 17:02

guilhermeleobas requested review from kshitij12345 and zou3519 and removed request for mruberry and ngimel October 9, 2023 17:21

kshitij12345 reviewed Oct 9, 2023

View reviewed changes

kshitij12345 approved these changes Oct 9, 2023

View reviewed changes

guilhermeleobas added the release notes: torch.func release notes category for torch.vmap or torch.func.* APIs label Oct 10, 2023

zou3519 reviewed Oct 24, 2023

View reviewed changes

docs/source/torch.rst Outdated Show resolved Hide resolved

zou3519 reviewed Oct 24, 2023

View reviewed changes

Update on "Add batch decomposition for torch.unsafe_chunk"

d8ab8ec

This updates the docs as well to show `torch.unsafe_chunk`. Should the `unsafe_*` functions should not appear in the docs? [ghstack-poisoned]

guilhermeleobas added a commit that referenced this pull request Oct 24, 2023

Add batch decomposition for torch.unsafe_chunk

8766d35

ghstack-source-id: 1a0a345 Pull Request resolved: #110862

zou3519 approved these changes Oct 24, 2023

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 26, 2023

pytorchmergebot added the merging label Oct 26, 2023

pytorchmergebot removed the merging label Oct 26, 2023

pytorchmergebot added the merging label Oct 27, 2023

pytorchmergebot removed the merging label Oct 27, 2023

pytorchmergebot added the merging label Oct 27, 2023

pytorchmergebot removed the merging label Oct 27, 2023

Update on "Add batch decomposition for torch.unsafe_chunk"

77082ac

This updates the docs as well to show `torch.unsafe_chunk`. Should the `unsafe_*` functions should not appear in the docs? [ghstack-poisoned]

Update on "Add batch decomposition for torch.unsafe_chunk"

3068b1d

This updates the docs as well to show `torch.unsafe_chunk`. Should the `unsafe_*` functions should not appear in the docs? [ghstack-poisoned]

guilhermeleobas added a commit that referenced this pull request Oct 30, 2023

Add batch decomposition for torch.unsafe_chunk

d18ff68

ghstack-source-id: b873d23 Pull Request resolved: #110862

pytorchmergebot added the merging label Oct 31, 2023

pytorchmergebot added Merged and removed merging labels Oct 31, 2023

pytorchmergebot closed this in b8a10a8 Oct 31, 2023

facebook-github-bot deleted the gh/guilhermeleobas/8/head branch November 3, 2023 14:27

Add batch decomposition for torch.unsafe_chunk #110862

Add batch decomposition for torch.unsafe_chunk #110862

Uh oh!

Conversation

guilhermeleobas commented Oct 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Oct 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110862

✅ No Failures

Uh oh!

kshitij12345 Oct 9, 2023

Choose a reason for hiding this comment

Uh oh!

kshitij12345 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zou3519 left a comment

Choose a reason for hiding this comment

Uh oh!

guilhermeleobas commented Oct 26, 2023

Uh oh!

pytorchmergebot commented Oct 26, 2023

Merge failed

Uh oh!

guilhermeleobas commented Oct 27, 2023

Uh oh!

pytorchmergebot commented Oct 27, 2023

Merge failed

Uh oh!

guilhermeleobas commented Oct 27, 2023

Uh oh!

pytorchmergebot commented Oct 27, 2023

Merge failed

Uh oh!

guilhermeleobas commented Oct 31, 2023

Uh oh!

pytorchmergebot commented Oct 31, 2023

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

guilhermeleobas commented Oct 9, 2023 •

edited

Loading

pytorch-bot bot commented Oct 9, 2023 •

edited

Loading