Nvfuser cpp api deprecation attempt 2 #110881
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110881
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit cd8ba03 with merge base 4b881b0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
At least in the repro in #110857 , we are not throwing any warning when users are just running vanilla torchscript. |
mikaylagawarecki
added
the
triaged
davidberard98
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
@jjsjann123 says the repro doesn't throw warnings now, so LGTM
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
jjsjann123
added a commit
to NVIDIA/Fuser
that referenced
this pull request
Oct 10, 2023
This is to follow up with upstream pytorch's code removal in pytorch/pytorch#110881
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attempting to re-try #110318 deprecating nvfuser c++ API
warning has been updated to TORCH_WARN_ONCE;
Warning thrown inside torch::jit::fuser::cuda::isEnabled() is turned off and will be deprecated when we pulled out TorchScript integration in the follow up PR.