[dtensor] make replicate -> partial do division instead #110898
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR switches the replicate -> partial to do division instead of zeroing out other ranks, it preserve same numerics, but avoid the per-rank behavior difference, and friendly to torch compile [ghstack-poisoned]
wanchaol
requested review from
H-Huang,
awgu,
d4l3k,
fduwjj,
fegin,
kiukchung,
kwen2501,
mrshenli,
rohan-varma,
wz337 and
zhaojuanmao
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110898
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 75a68e2 with merge base 201d02e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR switches the replicate -> partial to do division instead of zeroing out other ranks, it preserve same numerics, but avoid the per-rank behavior difference, and friendly to torch compile [ghstack-poisoned]
fduwjj
approved these changes
Oct 10, 2023
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 11, 2023
make random ops be a set instead of list Pull Request resolved: #110900 Approved by: https://github.com/fduwjj ghstack dependencies: #110898
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 12, 2023
) as titled Pull Request resolved: #111091 Approved by: https://github.com/awgu, https://github.com/wz337 ghstack dependencies: #110898, #110900
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This PR switches the replicate -> partial to do division instead of
zeroing out other ranks, it preserve same numerics, but avoid the
per-rank behavior difference, and friendly to torch compile