[dynamo] add infinite generators itertools.{count, repeat, cycle}
#110967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110967
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9d1692c with merge base f74d766 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "release notes: dynamo" |
ezyang
reviewed
Oct 10, 2023
ezyang
reviewed
Oct 10, 2023
…uang/infinite-iterators
jon-chuang
commented
Oct 10, 2023
jon-chuang
commented
Oct 10, 2023
cpuhrsch
added
the
triaged
This comment was marked as outdated.
This comment was marked as outdated.
…uang/infinite-iterators
jon-chuang
commented
Oct 12, 2023
ezyang
reviewed
Oct 13, 2023
ezyang
reviewed
Oct 13, 2023
ezyang
reviewed
Oct 13, 2023
ezyang
reviewed
Oct 13, 2023
ezyang
reviewed
Oct 13, 2023
ezyang
reviewed
Oct 13, 2023
…uang/infinite-iterators
|
@pytorchbot merge |
4 tasks
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
…ytorch#110967) Fixes https://github.com/pytorch/pytorch/pull/110953/files#r1352868935 Depends on: pytorch#110953 Why not use these for `repeat(item, count)`: > These are not preferred as they return an opaque VariableTracker. In particular, one cannot do `enumerate(repeat(1))`. `repeat(1, 10)` benefits from the integration enjoyed by `ListVariableIterator` Follow ups: - [ ] make listiterator an IteratorVariable, define iterator integrations on base IteratorVariable where unspecialized pytorch#110967 (comment) - Please make a new issue for this - [ ] explore integrating cpython itertools test suite pytorch#110967 (comment) - [ ] Use something other than `StopIteration` to handle iterator termination pytorch#110967 (comment) - [ ] Add test case for consuming iterator simultaneously from two code points https://github.com/pytorch/pytorch/pull/110967/files#r1358325511 Pull Request resolved: pytorch#110967 Approved by: https://github.com/ezyang
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
…ytorch#110967) Fixes https://github.com/pytorch/pytorch/pull/110953/files#r1352868935 Depends on: pytorch#110953 Why not use these for `repeat(item, count)`: > These are not preferred as they return an opaque VariableTracker. In particular, one cannot do `enumerate(repeat(1))`. `repeat(1, 10)` benefits from the integration enjoyed by `ListVariableIterator` Follow ups: - [ ] make listiterator an IteratorVariable, define iterator integrations on base IteratorVariable where unspecialized pytorch#110967 (comment) - Please make a new issue for this - [ ] explore integrating cpython itertools test suite pytorch#110967 (comment) - [ ] Use something other than `StopIteration` to handle iterator termination pytorch#110967 (comment) - [ ] Add test case for consuming iterator simultaneously from two code points https://github.com/pytorch/pytorch/pull/110967/files#r1358325511 Pull Request resolved: pytorch#110967 Approved by: https://github.com/ezyang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/pytorch/pytorch/pull/110953/files#r1352868935
Depends on: #110953
Why not use these for
repeat(item, count):Follow ups:
itertools.{count, repeat, cycle}#110967 (comment)itertools.{count, repeat, cycle}#110967 (comment)StopIterationto handle iterator termination [dynamo] add infinite generatorsitertools.{count, repeat, cycle}#110967 (comment)cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov @kadeng @ezyang