KEMBAR78
Public API for constructing NT with jagged layout from tensor list by jbschlosser · Pull Request #111078 · pytorch/pytorch · GitHub
Skip to content

Public API for constructing NT with jagged layout from tensor list #111078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Public API for constructing NT with jagged layout from tensor list #111078

wants to merge 5 commits into from

Conversation

@jbschlosser
Copy link
Contributor

@jbschlosser jbschlosser commented Oct 11, 2023 •
edited
Loading

Stack from ghstack (oldest at bottom):

This PR:

  • Introduces a new layout: torch.jagged
  • Expands torch.nested.nested_tensor(tensor_list) to accept a layout kwarg with the default set to torch.strided

TODO: non-copying constructor

@jbschlosser jbschlosser mentioned this pull request Oct 11, 2023
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 11, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111078

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e5d887c with merge base de1ca4a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

jbschlosser added a commit that referenced this pull request Oct 11, 2023
@jbschlosser
Public API for constructing NT with jagged layout from tensor list
ad4a411 
ghstack-source-id: 4f5681e
Pull Request resolved: #111078
@jbschlosser jbschlosser marked this pull request as draft October 11, 2023 20:20
cpuhrsch
cpuhrsch reviewed Oct 12, 2023
View reviewed changes
cpuhrsch
cpuhrsch reviewed Oct 12, 2023
View reviewed changes
@jbschlosser
Update on "Public API for constructing NT with jagged layout from ten…
d424b39 
…sor list"


This PR:
* Introduces a new layout: `torch.jagged`
* Expands `torch.nested.nested_tensor(tensor_list)` to accept a `layout` kwarg with the default set to `torch.strided`
* TODO: Tests, a non-copying constructor, etc.

[ghstack-poisoned]
@jbschlosser jbschlosser force-pushed the gh/jbschlosser/93/head branch from 54f45a2 to d424b39 Compare October 12, 2023 16:42
jbschlosser added a commit that referenced this pull request Oct 12, 2023
@jbschlosser
Public API for constructing NT with jagged layout from tensor list
5db617e 
ghstack-source-id: 92b2d08
Pull Request resolved: #111078
@jbschlosser jbschlosser added topic: improvements topic category release notes: nested tensor Changes that have a direct impact on nested tensors labels Oct 12, 2023
@jbschlosser
Update on "Public API for constructing NT with jagged layout from ten…
a53796b 
…sor list"


This PR:
* Introduces a new layout: `torch.jagged`
* Expands `torch.nested.nested_tensor(tensor_list)` to accept a `layout` kwarg with the default set to `torch.strided`
* TODO: Tests, a non-copying constructor, etc.

[ghstack-poisoned]
jbschlosser added a commit that referenced this pull request Oct 12, 2023
@jbschlosser
Public API for constructing NT with jagged layout from tensor list
6432144 
ghstack-source-id: 7a9dac8
Pull Request resolved: #111078
@jbschlosser jbschlosser marked this pull request as ready for review October 12, 2023 19:42
This was referenced Oct 12, 2023
Merged
Merged
@jbschlosser
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 12, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

soulitzer
soulitzer approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@soulitzer soulitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHIP

@jcaip jcaip mentioned this pull request Oct 12, 2023
Closed
@jcaip jcaip force-pushed the gh/jbschlosser/93/head branch from a53796b to f080c6d Compare October 12, 2023 23:17
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: New commits were pushed while merging. Please rerun the merge command.

Details for Dev Infra team Raised by workflow job

@jcaip jcaip force-pushed the gh/jbschlosser/93/head branch from f080c6d to e5d887c Compare October 12, 2023 23:50
@jcaip
Copy link
Contributor

jcaip commented Oct 13, 2023

@pytorchbot merge

@jcaip
Copy link
Contributor

jcaip commented Oct 13, 2023

Sorry @jbschlosser, I forgot I rebased on top of this PR when I force pushed.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@jbschlosser jbschlosser mentioned this pull request Oct 13, 2023
Closed
@facebook-github-bot facebook-github-bot deleted the gh/jbschlosser/93/head branch October 16, 2023 14:24
@cpuhrsch cpuhrsch mentioned this pull request Oct 18, 2023
Open
5 tasks
@jbschlosser jbschlosser mentioned this pull request Oct 30, 2023
Open
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpuhrsch cpuhrsch cpuhrsch approved these changes

@soulitzer soulitzer soulitzer approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: nested tensor Changes that have a direct impact on nested tensors topic: improvements topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jbschlosser @pytorchmergebot @jcaip @cpuhrsch @soulitzer