[AOTInductor] Improve validation for C++ wrapper codegen #111102
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111102
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 9d91b5b with merge base 74b1f4f ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "topic: not user facing" |
khabinov
force-pushed
the
oleg/codegen-validation
branch
2 times, most recently
from
d95892d to
96dd273
Compare
khabinov
force-pushed
the
oleg/codegen-validation
branch
from
96dd273 to
43d345e
Compare
desertfire
reviewed
Oct 12, 2023
There was a problem hiding this comment.
@chunyuan-w , we are changing this silent fallback behavior for cpp_wrapper codegen as we have a pretty good coverage now.
desertfire
approved these changes
Oct 12, 2023
khabinov
force-pushed
the
oleg/codegen-validation
branch
from
43d345e to
eb71de1
Compare
jgong5
approved these changes
Oct 13, 2023
khabinov
force-pushed
the
oleg/codegen-validation
branch
from
eb71de1 to
9d91b5b
Compare
chunyuan-w
approved these changes
Oct 13, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a reimplementation of #111089
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler